[flac-dev] Patch to fix compiler warnings and error status collisions

Erik de Castro Lopo mle+la at mega-nerd.com
Wed Apr 9 01:12:14 PDT 2014


Erik de Castro Lopo wrote:

> This could also be fixed by adding a:
> 
>    decoder->protected_->initstate
> 
> and using that correctly. Right?
> 
> I'm going to play with this idea.

That fixed it. Commit is here:

    https://git.xiph.org/?p=flac.git;a=commit;h=3f5208c30022b7cbd0b9095ad3550c4f6cb348c9


What didn't get added was this:

    diff --git a/src/flac/utils.c b/src/flac/utils.c
    index 4bf05e2..941a958 100644
    --- a/src/flac/utils.c
    +++ b/src/flac/utils.c
    @@ -35,7 +35,7 @@
     #ifdef HAVE_TERMIOS_H
     # include <termios.h>
     #endif
    -#ifdef GWINSZ_IN_SYS_IOCTL
    +#if !defined __ANDROID__
     # include <sys/ioctl.h>
     #endif
     #endif

because that seemed completely un-related. What's this bit all about?

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list