[flac-dev] Patch to fix compiler warnings and error status collisions

Erik de Castro Lopo mle+la at mega-nerd.com
Tue Apr 8 01:22:11 PDT 2014


Lenny Maiorani wrote:

> FLAC__StreamDecodeInitStatus is still there. It is simply another name
> for FLAC__StreamDecoderState. The API does not change here, other than
> the numerical value of the enums.

That is sufficient for an ABI change.

> However, the bug that exists is that the numerical value of the enums
> collide and are being used interchangeably in decoder->protected_->state,
> so they really should be the same enum, IMHO.

This could also be fixed by adding a:

   decoder->protected_->initstate

and using that correctly. Right?

I'm going to play with this idea.
 
Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/


More information about the flac-dev mailing list