[flac-dev] Patch to fix compiler warnings and error status collisions

[Erik de Castro Lopo]

Lenny Maiorani wrote:

> I am new around here, so I am not sure of all your procedures
> for submitting patches/pull requests.

A patch like you sent is fine. When I commit that I will add
a Patch-from line to the commit.

Otherwise, you can commit to you local repo and then use the git
format-patch sub command to create a set or patches that can
be attached to an email and sent to the list.

> The attached patch fixes all Clang compilation warnings.

I'll check this out.
 
> Note, some of these warnings were real problems. There is the
> potential for API users to misinterpret the state being returned
> since the return variable was of type FLAC__StreamDecoderState,
> but the value being returned was FLAC__StreamDecoderInitStatus.
> When FLAC__STREAM_DECODER_INIT_STATUS_ALREADY_INITIALIZED was
> returned in this case it was indistinguishable from
> FLAC__STREAM_DECODER_OGG_ERROR.

Problem is this patch changes the ABI because FLAC__StreamDecodeInitStatus
disappears from the API.

Is there some way this can be fixed without chaning the API/ABI?
 
Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/