[flac-dev] flac-dev Digest, Vol 100, Issue 42

Marcus Johnson bumblebritches57 at gmail.com
Mon Mar 18 03:07:27 PDT 2013 

"Aren't Windows users accustomed to this feature being missing anyway?"

I use Mac mostly now, but when I used Windows, now and then I always
expected the wildcard to work, it just worked on most things so it was
actually a bit of a pain in the ass when it didn't.


On Mon, Mar 18, 2013 at 5:35 AM, <flac-dev-request at xiph.org> wrote:

> Send flac-dev mailing list submissions to
>         flac-dev at xiph.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         http://lists.xiph.org/mailman/listinfo/flac-dev
> or, via email, send a message with subject or body 'help' to
>         flac-dev-request at xiph.org
>
> You can reach the person managing the list at
>         flac-dev-owner at xiph.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of flac-dev digest..."
>
> Today's Topics:
>
>    1. Re: MSVC project updates (Erik de Castro Lopo)
>    2. Re: Patch to add Unicode filename support for win32 flac (JonY)
>    3. Re: Patch to add Unicode filename support for win32 flac
>       (Erik de Castro Lopo)
>    4. Re: Patch to add Unicode filename support for win32 flac (LRN)
>    5. Re: Patch to add Unicode filename support for win32 flac (LRN)
>    6. Re: Patch to add Unicode filename support for win32 flac
>       (Brian Willoughby)
>    7. Re: Patch to add Unicode filename support for win32 flac
>       (Erik de Castro Lopo)
>    8. Re: Patch to add Unicode filename support for win32 flac (JonY)
>
>
> ---------- Forwarded message ----------
> From: Erik de Castro Lopo <mle+la at mega-nerd.com>
> To: flac-dev at xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 06:29:22 +1100
> Subject: Re: [flac-dev] MSVC project updates
> Janne Hyvärinen wrote:
>
> > One more set of MSVC project updates. Changed ogg_static.lib to
> > libogg_static.lib as that's the name latest version uses. Removed MSVC
> > 6.0 related parts from README and tweaked info there to be more
> > up-to-date. Also changed nasmw.exe into nasm.exe as nasmw.exe has been
> > long gone.
> > LibFLAC_dynamic was complaining in debug mode about conflicts with
> > libcmt, I excluded it from the project there as I saw no other way to
> > solve the problem.
>
> Applied. Thanks.
>
> Erik
> --
> ----------------------------------------------------------------------
> Erik de Castro Lopo
> http://www.mega-nerd.com/
>
>
>
> ---------- Forwarded message ----------
> From: JonY <10walls at gmail.com>
> To: flac-dev at xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 06:10:44 +0800
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> On 3/17/2013 23:01, LRN wrote:
> >> All those ifdefs will at least be confined rather than spread out
> >> through the code.
> > I did it plibc-style:
> >
> > in compat.h:
> > #if defined(_WIN32)
> > #define FOPEN grabbag__fopen_utf8_wrapper
> > #else
> > #define FOPEN fopen
> > #endif
> >
> > in grabbag:
> > #if defined(_WIN32)
> > <implement grabbag__fopen_utf8_wrapper, which has the same signature
> > as fopen, but does utf8->utf16 conversion internally, then calls wfopen>
> > #endif
> >
> > and replace "fopen" with "FOPEN" everywhere else.
>
> Don't do that, it leaks into the system headers and breaks mingw if
> FLAC_USE_FOPEN_UTF8 is defined.
>
> Call the wrappers directly instead of using a macro.
>
>
>
> ---------- Forwarded message ----------
> From: Erik de Castro Lopo <mle+la at mega-nerd.com>
> To: flac-dev at xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 09:37:56 +1100
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> JonY wrote:
>
> > On 3/17/2013 23:01, LRN wrote:
> > >> All those ifdefs will at least be confined rather than spread out
> > >> through the code.
> > > I did it plibc-style:
> > >
> > > in compat.h:
> > > #if defined(_WIN32)
> > > #define FOPEN grabbag__fopen_utf8_wrapper
> > > #else
> > > #define FOPEN fopen
> > > #endif
> > >
> > > in grabbag:
> > > #if defined(_WIN32)
> > > <implement grabbag__fopen_utf8_wrapper, which has the same signature
> > > as fopen, but does utf8->utf16 conversion internally, then calls
> wfopen>
> > > #endif
> > >
> > > and replace "fopen" with "FOPEN" everywhere else.
> >
> > Don't do that, it leaks into the system headers and breaks mingw if
> > FLAC_USE_FOPEN_UTF8 is defined.
> >
> > Call the wrappers directly instead of using a macro.
>
> +1
>
> Yep, I prefer not to have too much #ifdef hackery.
>
> In my recent replacement of all the sprintf/_snprintf stuff, I relaced all
> the
> calls with a call to flac_snprintf() and localised #ifdef hackery to the
> implementation of that function.
>
> >From a patch cleanliness POV, I like to see the new functionality added in
> one patch and a separate patch to change all the old function usage to the
> new function usage. For example, in commit 06af237c I added the new
> flac_snprintf() function and in commit 3c84f9e8 I replaced all the old
> calls to sprintf/_snprintf.
>
> Cheers,
> Erik
> --
> ----------------------------------------------------------------------
> Erik de Castro Lopo
> http://www.mega-nerd.com/
>
>
>
> ---------- Forwarded message ----------
> From: LRN <lrn1986 at gmail.com>
> To: flac-dev at xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 05:55:07 +0400
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 18.03.2013 02:10, JonY wrote:
> > On 3/17/2013 23:01, LRN wrote:
> >>> All those ifdefs will at least be confined rather than spread
> >>> out through the code.
> >> I did it plibc-style:
> >>
> >> in compat.h: #if defined(_WIN32) #define FOPEN
> >> grabbag__fopen_utf8_wrapper #else #define FOPEN fopen #endif
> >>
> >> in grabbag: #if defined(_WIN32) <implement
> >> grabbag__fopen_utf8_wrapper, which has the same signature as
> >> fopen, but does utf8->utf16 conversion internally, then calls
> >> wfopen> #endif
> >>
> >> and replace "fopen" with "FOPEN" everywhere else.
> >
> > Don't do that, it leaks into the system headers
> How? compat.h is not a public header, it is only used internally in
> FLAC. And i don't think that system headers have defines for "FOPEN"
> and such.
>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (MingW32)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQEcBAEBAgAGBQJRRnP7AAoJEOs4Jb6SI2CwxWoH/13eGOZb62iAm4SzkDFQ6/Bh
> 2Goz3lz+9fK4Gq+tXyfPmXC1JabLdM1vnw43QgkAVWr3OrJ2+AN+LHocP9+YCYG4
> ckd5Eisi32taDr3+CnaJzOrYQnaeD926iPC2vQoVOMIniGWTRVzIIYxood0gGXd3
> oa5hPMvq1t/TXyKudSt8Jimeoe6vyoaLcBJCMykn9B5qh//ryiajGJlwQgicessb
> Rzw0/VgbLcck3XLyzm7gfsXxiYhRjeSalZyPxYw6DE8rsARxswk1TfWLB7faPAiI
> spaA2mEX7iQz9GPmKlhil/Q/rzsn3vt8lgHbC+WDD0843kkaC3MWPvPdqqsbFh4=
> =3u0R
> -----END PGP SIGNATURE-----
>
>
>
> ---------- Forwarded message ----------
> From: LRN <lrn1986 at gmail.com>
> To: flac-dev at xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 05:57:21 +0400
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 18.03.2013 02:37, Erik de Castro Lopo wrote:
> > JonY wrote:
> >> On 3/17/2013 23:01, LRN wrote:
> >>>> All those ifdefs will at least be confined rather than spread
> >>>> out through the code.
> >>> I did it plibc-style:
> >>>
> >>> in compat.h: #if defined(_WIN32) #define FOPEN
> >>> grabbag__fopen_utf8_wrapper #else #define FOPEN fopen #endif
> >>>
> >>> in grabbag: #if defined(_WIN32) <implement
> >>> grabbag__fopen_utf8_wrapper, which has the same signature as
> >>> fopen, but does utf8->utf16 conversion internally, then calls
> >>> wfopen> #endif
> >>>
> >>> and replace "fopen" with "FOPEN" everywhere else.
> >>
> >> Don't do that, it leaks into the system headers and breaks mingw
> >> if FLAC_USE_FOPEN_UTF8 is defined.
> >>
> >> Call the wrappers directly instead of using a macro.
> >
> > +1
> >
> > Yep, I prefer not to have too much #ifdef hackery.
> >
> > In my recent replacement of all the sprintf/_snprintf stuff, I
> > relaced all the calls with a call to flac_snprintf() and localised
> > #ifdef hackery to the implementation of that function.
> >
> > From a patch cleanliness POV, I like to see the new functionality
> > added in one patch and a separate patch to change all the old
> > function usage to the new function usage. For example, in commit
> > 06af237c I added the new flac_snprintf() function and in commit
> > 3c84f9e8 I replaced all the old calls to sprintf/_snprintf.
> /me shrugs
> Sure, that'll work too.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (MingW32)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQEcBAEBAgAGBQJRRnSAAAoJEOs4Jb6SI2CwPmoIAIM2pFUjl+TNDnPkDCBkLWPy
> zf58O5s8R+2S1uNfpd8fQrheZKdK8kSitJj9XYGELo+POyn8pJGEBjYvZyqVls88
> gAHaE5wWgV5aSYmHcwQD8aXCB2LP9Lkpk01rvt6lZ9grw15nWUyhmiPd3uyQYwOD
> ZGrqAS661d4XoSP5N0hi86mUf9NcM6xXacDY+leRnSNowIrtbnCR0vhQJoHMpY7U
> fWB6dM4YEgZmCbj6he9ZHbXemlMiK+rRkoEsPPcAobGCIga6I0il6j/3JxI8bKCl
> VF+4Iz0APw22/+ck6K+tfde/9JGraZT2HsYm2PNAcPiuZPmvP0oTvQrGLkRJzr0=
> =GIQw
> -----END PGP SIGNATURE-----
>
>
>
> ---------- Forwarded message ----------
> From: Brian Willoughby <brianw at sounds.wa.com>
> To: FLAC Development emailinglist <flac-dev at xiph.org>
> Cc:
> Date: Sun, 17 Mar 2013 19:53:09 -0700
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
>
> On Mar 17, 2013, at 03:57, LRN wrote:
>
>> /me looks at chmod and utime wrappers:
>> Ah, i knew i've missed something! :)
>> Also, i didn't consider wildcards (i thought shell was supposed to
>> handle them...).
>>
>
>
> I believe that shell does handle wildcards on all Unix variants, including
> OSX. Since Windows does not handle them, I suggest that the main flac code
> not be littered with code that's not necessary on the primary platforms.
> Aren't Windows users accustomed to this feature being missing anyway?
>
> Brian
>
>
>
>
> ---------- Forwarded message ----------
> From: Erik de Castro Lopo <mle+la at mega-nerd.com>
> To: flac-dev at xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 17:55:22 +1100
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> Brian Willoughby wrote:
>
> > I believe that shell does handle wildcards on all Unix variants,
> > including OSX.
>
> Yes.
>
> > Since Windows does not handle them, I suggest that the
> > main flac code not be littered with code that's not necessary on the
> > primary platforms.
>
> No, the flac code will not be "littered with code that's not necessary
> on the primary platforms".
>
> There will be some windows specific code in a new file, a bunch of
> replacements of existing fopen() calls with flac_fopen() (similarly
> for chmod and utime) and the main function for the flac and metaflac
> executables will have an additional:
>
>     #ifdef _WIN32
>         if (!convert_argv_to_utf8(&argc, &argv))
>                 flac__utils_printf(stderr, 1, "ERROR: yada yada\n");
>     #endif
>
> This is a small un-obtrusive change that I fully support.
>
> I would however like to see it sooner rather than later so we can get
> this damn thing released :-).
>
> Erik
> --
> ----------------------------------------------------------------------
> Erik de Castro Lopo
> http://www.mega-nerd.com/
>
>
>
> ---------- Forwarded message ----------
> From: JonY <10walls at gmail.com>
> To: flac-dev at xiph.org
> Cc:
> Date: Mon, 18 Mar 2013 17:35:14 +0800
> Subject: Re: [flac-dev] Patch to add Unicode filename support for win32
> flac
> On 3/18/2013 14:55, Erik de Castro Lopo wrote:
> > Brian Willoughby wrote:
> >
> >> I believe that shell does handle wildcards on all Unix variants,
> >> including OSX.
> >
> > Yes.
> >
> >> Since Windows does not handle them, I suggest that the
> >> main flac code not be littered with code that's not necessary on the
> >> primary platforms.
> >
> > No, the flac code will not be "littered with code that's not necessary
> > on the primary platforms".
> >
> > There will be some windows specific code in a new file, a bunch of
> > replacements of existing fopen() calls with flac_fopen() (similarly
> > for chmod and utime) and the main function for the flac and metaflac
> > executables will have an additional:
> >
> >     #ifdef _WIN32
> >       if (!convert_argv_to_utf8(&argc, &argv))
> >               flac__utils_printf(stderr, 1, "ERROR: yada yada\n");
> >     #endif
> >
> > This is a small un-obtrusive change that I fully support.
> >
> > I would however like to see it sooner rather than later so we can get
> > this damn thing released :-).
> >
>
> Before anyone does anything, see __wgetmainargs
> <http://msdn.microsoft.com/en-us/library/ff770599.aspx>.
>
> It can expand wildcards. Since it already provides argc/argv/env, it is
> more a less a drop-in replacement for the main() arguments.
>
>
>
> _______________________________________________
> flac-dev mailing list
> flac-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20130318/6d12b3d9/attachment-0001.htm

More information about the flac-dev mailing list