<div dir="ltr">"<span style="font-family:arial,sans-serif;font-size:12.666666984558105px">Aren't Windows users accustomed to this feature being missing anyway?</span>"<div><br></div><div style>I use Mac mostly now, but when I used Windows, now and then I always expected the wildcard to work, it just worked on most things so it was actually a bit of a pain in the ass when it didn't.</div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Mar 18, 2013 at 5:35 AM, <span dir="ltr"><<a href="mailto:flac-dev-request@xiph.org" target="_blank">flac-dev-request@xiph.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Send flac-dev mailing list submissions to<br>
<a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://lists.xiph.org/mailman/listinfo/flac-dev" target="_blank">http://lists.xiph.org/mailman/listinfo/flac-dev</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:flac-dev-request@xiph.org">flac-dev-request@xiph.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:flac-dev-owner@xiph.org">flac-dev-owner@xiph.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of flac-dev digest..."<br>
<br>Today's Topics:<br>
<br>
1. Re: MSVC project updates (Erik de Castro Lopo)<br>
2. Re: Patch to add Unicode filename support for win32 flac (JonY)<br>
3. Re: Patch to add Unicode filename support for win32 flac<br>
(Erik de Castro Lopo)<br>
4. Re: Patch to add Unicode filename support for win32 flac (LRN)<br>
5. Re: Patch to add Unicode filename support for win32 flac (LRN)<br>
6. Re: Patch to add Unicode filename support for win32 flac<br>
(Brian Willoughby)<br>
7. Re: Patch to add Unicode filename support for win32 flac<br>
(Erik de Castro Lopo)<br>
8. Re: Patch to add Unicode filename support for win32 flac (JonY)<br>
<br><br>---------- Forwarded message ----------<br>From: Erik de Castro Lopo <<a href="mailto:mle%2Bla@mega-nerd.com">mle+la@mega-nerd.com</a>><br>To: <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>Cc: <br>
Date: Mon, 18 Mar 2013 06:29:22 +1100<br>Subject: Re: [flac-dev] MSVC project updates<br>Janne Hyvärinen wrote:<br>
<br>
> One more set of MSVC project updates. Changed ogg_static.lib to<br>
> libogg_static.lib as that's the name latest version uses. Removed MSVC<br>
> 6.0 related parts from README and tweaked info there to be more<br>
> up-to-date. Also changed nasmw.exe into nasm.exe as nasmw.exe has been<br>
> long gone.<br>
> LibFLAC_dynamic was complaining in debug mode about conflicts with<br>
> libcmt, I excluded it from the project there as I saw no other way to<br>
> solve the problem.<br>
<br>
Applied. Thanks.<br>
<br>
Erik<br>
--<br>
----------------------------------------------------------------------<br>
Erik de Castro Lopo<br>
<a href="http://www.mega-nerd.com/" target="_blank">http://www.mega-nerd.com/</a><br>
<br>
<br><br>---------- Forwarded message ----------<br>From: JonY <<a href="mailto:10walls@gmail.com">10walls@gmail.com</a>><br>To: <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>Cc: <br>Date: Mon, 18 Mar 2013 06:10:44 +0800<br>
Subject: Re: [flac-dev] Patch to add Unicode filename support for win32 flac<br>On 3/17/2013 23:01, LRN wrote:<br>
>> All those ifdefs will at least be confined rather than spread out<br>
>> through the code.<br>
> I did it plibc-style:<br>
><br>
> in compat.h:<br>
> #if defined(_WIN32)<br>
> #define FOPEN grabbag__fopen_utf8_wrapper<br>
> #else<br>
> #define FOPEN fopen<br>
> #endif<br>
><br>
> in grabbag:<br>
> #if defined(_WIN32)<br>
> <implement grabbag__fopen_utf8_wrapper, which has the same signature<br>
> as fopen, but does utf8->utf16 conversion internally, then calls wfopen><br>
> #endif<br>
><br>
> and replace "fopen" with "FOPEN" everywhere else.<br>
<br>
Don't do that, it leaks into the system headers and breaks mingw if<br>
FLAC_USE_FOPEN_UTF8 is defined.<br>
<br>
Call the wrappers directly instead of using a macro.<br>
<br>
<br><br>---------- Forwarded message ----------<br>From: Erik de Castro Lopo <<a href="mailto:mle%2Bla@mega-nerd.com">mle+la@mega-nerd.com</a>><br>To: <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>Cc: <br>
Date: Mon, 18 Mar 2013 09:37:56 +1100<br>Subject: Re: [flac-dev] Patch to add Unicode filename support for win32 flac<br>JonY wrote:<br>
<br>
> On 3/17/2013 23:01, LRN wrote:<br>
> >> All those ifdefs will at least be confined rather than spread out<br>
> >> through the code.<br>
> > I did it plibc-style:<br>
> ><br>
> > in compat.h:<br>
> > #if defined(_WIN32)<br>
> > #define FOPEN grabbag__fopen_utf8_wrapper<br>
> > #else<br>
> > #define FOPEN fopen<br>
> > #endif<br>
> ><br>
> > in grabbag:<br>
> > #if defined(_WIN32)<br>
> > <implement grabbag__fopen_utf8_wrapper, which has the same signature<br>
> > as fopen, but does utf8->utf16 conversion internally, then calls wfopen><br>
> > #endif<br>
> ><br>
> > and replace "fopen" with "FOPEN" everywhere else.<br>
><br>
> Don't do that, it leaks into the system headers and breaks mingw if<br>
> FLAC_USE_FOPEN_UTF8 is defined.<br>
><br>
> Call the wrappers directly instead of using a macro.<br>
<br>
+1<br>
<br>
Yep, I prefer not to have too much #ifdef hackery.<br>
<br>
In my recent replacement of all the sprintf/_snprintf stuff, I relaced all the<br>
calls with a call to flac_snprintf() and localised #ifdef hackery to the<br>
implementation of that function.<br>
<br>
>From a patch cleanliness POV, I like to see the new functionality added in<br>
one patch and a separate patch to change all the old function usage to the<br>
new function usage. For example, in commit 06af237c I added the new<br>
flac_snprintf() function and in commit 3c84f9e8 I replaced all the old<br>
calls to sprintf/_snprintf.<br>
<br>
Cheers,<br>
Erik<br>
--<br>
----------------------------------------------------------------------<br>
Erik de Castro Lopo<br>
<a href="http://www.mega-nerd.com/" target="_blank">http://www.mega-nerd.com/</a><br>
<br>
<br><br>---------- Forwarded message ----------<br>From: LRN <<a href="mailto:lrn1986@gmail.com">lrn1986@gmail.com</a>><br>To: <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>Cc: <br>Date: Mon, 18 Mar 2013 05:55:07 +0400<br>
Subject: Re: [flac-dev] Patch to add Unicode filename support for win32 flac<br>-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
On 18.03.2013 02:10, JonY wrote:<br>
> On 3/17/2013 23:01, LRN wrote:<br>
>>> All those ifdefs will at least be confined rather than spread<br>
>>> out through the code.<br>
>> I did it plibc-style:<br>
>><br>
>> in compat.h: #if defined(_WIN32) #define FOPEN<br>
>> grabbag__fopen_utf8_wrapper #else #define FOPEN fopen #endif<br>
>><br>
>> in grabbag: #if defined(_WIN32) <implement<br>
>> grabbag__fopen_utf8_wrapper, which has the same signature as<br>
>> fopen, but does utf8->utf16 conversion internally, then calls<br>
>> wfopen> #endif<br>
>><br>
>> and replace "fopen" with "FOPEN" everywhere else.<br>
><br>
> Don't do that, it leaks into the system headers<br>
How? compat.h is not a public header, it is only used internally in<br>
FLAC. And i don't think that system headers have defines for "FOPEN"<br>
and such.<br>
<br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.11 (MingW32)<br>
Comment: Using GnuPG with Thunderbird - <a href="http://www.enigmail.net/" target="_blank">http://www.enigmail.net/</a><br>
<br>
iQEcBAEBAgAGBQJRRnP7AAoJEOs4Jb6SI2CwxWoH/13eGOZb62iAm4SzkDFQ6/Bh<br>
2Goz3lz+9fK4Gq+tXyfPmXC1JabLdM1vnw43QgkAVWr3OrJ2+AN+LHocP9+YCYG4<br>
ckd5Eisi32taDr3+CnaJzOrYQnaeD926iPC2vQoVOMIniGWTRVzIIYxood0gGXd3<br>
oa5hPMvq1t/TXyKudSt8Jimeoe6vyoaLcBJCMykn9B5qh//ryiajGJlwQgicessb<br>
Rzw0/VgbLcck3XLyzm7gfsXxiYhRjeSalZyPxYw6DE8rsARxswk1TfWLB7faPAiI<br>
spaA2mEX7iQz9GPmKlhil/Q/rzsn3vt8lgHbC+WDD0843kkaC3MWPvPdqqsbFh4=<br>
=3u0R<br>
-----END PGP SIGNATURE-----<br>
<br>
<br><br>---------- Forwarded message ----------<br>From: LRN <<a href="mailto:lrn1986@gmail.com">lrn1986@gmail.com</a>><br>To: <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>Cc: <br>Date: Mon, 18 Mar 2013 05:57:21 +0400<br>
Subject: Re: [flac-dev] Patch to add Unicode filename support for win32 flac<br>-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
On 18.03.2013 02:37, Erik de Castro Lopo wrote:<br>
> JonY wrote:<br>
>> On 3/17/2013 23:01, LRN wrote:<br>
>>>> All those ifdefs will at least be confined rather than spread<br>
>>>> out through the code.<br>
>>> I did it plibc-style:<br>
>>><br>
>>> in compat.h: #if defined(_WIN32) #define FOPEN<br>
>>> grabbag__fopen_utf8_wrapper #else #define FOPEN fopen #endif<br>
>>><br>
>>> in grabbag: #if defined(_WIN32) <implement<br>
>>> grabbag__fopen_utf8_wrapper, which has the same signature as<br>
>>> fopen, but does utf8->utf16 conversion internally, then calls<br>
>>> wfopen> #endif<br>
>>><br>
>>> and replace "fopen" with "FOPEN" everywhere else.<br>
>><br>
>> Don't do that, it leaks into the system headers and breaks mingw<br>
>> if FLAC_USE_FOPEN_UTF8 is defined.<br>
>><br>
>> Call the wrappers directly instead of using a macro.<br>
><br>
> +1<br>
><br>
> Yep, I prefer not to have too much #ifdef hackery.<br>
><br>
> In my recent replacement of all the sprintf/_snprintf stuff, I<br>
> relaced all the calls with a call to flac_snprintf() and localised<br>
> #ifdef hackery to the implementation of that function.<br>
><br>
> From a patch cleanliness POV, I like to see the new functionality<br>
> added in one patch and a separate patch to change all the old<br>
> function usage to the new function usage. For example, in commit<br>
> 06af237c I added the new flac_snprintf() function and in commit<br>
> 3c84f9e8 I replaced all the old calls to sprintf/_snprintf.<br>
/me shrugs<br>
Sure, that'll work too.<br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.11 (MingW32)<br>
Comment: Using GnuPG with Thunderbird - <a href="http://www.enigmail.net/" target="_blank">http://www.enigmail.net/</a><br>
<br>
iQEcBAEBAgAGBQJRRnSAAAoJEOs4Jb6SI2CwPmoIAIM2pFUjl+TNDnPkDCBkLWPy<br>
zf58O5s8R+2S1uNfpd8fQrheZKdK8kSitJj9XYGELo+POyn8pJGEBjYvZyqVls88<br>
gAHaE5wWgV5aSYmHcwQD8aXCB2LP9Lkpk01rvt6lZ9grw15nWUyhmiPd3uyQYwOD<br>
ZGrqAS661d4XoSP5N0hi86mUf9NcM6xXacDY+leRnSNowIrtbnCR0vhQJoHMpY7U<br>
fWB6dM4YEgZmCbj6he9ZHbXemlMiK+rRkoEsPPcAobGCIga6I0il6j/3JxI8bKCl<br>
VF+4Iz0APw22/+ck6K+tfde/9JGraZT2HsYm2PNAcPiuZPmvP0oTvQrGLkRJzr0=<br>
=GIQw<br>
-----END PGP SIGNATURE-----<br>
<br>
<br><br>---------- Forwarded message ----------<br>From: Brian Willoughby <<a href="mailto:brianw@sounds.wa.com">brianw@sounds.wa.com</a>><br>To: FLAC Development emailinglist <<a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a>><br>
Cc: <br>Date: Sun, 17 Mar 2013 19:53:09 -0700<br>Subject: Re: [flac-dev] Patch to add Unicode filename support for win32 flac<br><br>
On Mar 17, 2013, at 03:57, LRN wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
/me looks at chmod and utime wrappers:<br>
Ah, i knew i've missed something! :)<br>
Also, i didn't consider wildcards (i thought shell was supposed to<br>
handle them...).<br>
</blockquote>
<br>
<br>
I believe that shell does handle wildcards on all Unix variants, including OSX. Since Windows does not handle them, I suggest that the main flac code not be littered with code that's not necessary on the primary platforms. Aren't Windows users accustomed to this feature being missing anyway?<br>
<br>
Brian<br>
<br>
<br>
<br><br>---------- Forwarded message ----------<br>From: Erik de Castro Lopo <<a href="mailto:mle%2Bla@mega-nerd.com">mle+la@mega-nerd.com</a>><br>To: <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>Cc: <br>
Date: Mon, 18 Mar 2013 17:55:22 +1100<br>Subject: Re: [flac-dev] Patch to add Unicode filename support for win32 flac<br>Brian Willoughby wrote:<br>
<br>
> I believe that shell does handle wildcards on all Unix variants,<br>
> including OSX.<br>
<br>
Yes.<br>
<br>
> Since Windows does not handle them, I suggest that the<br>
> main flac code not be littered with code that's not necessary on the<br>
> primary platforms.<br>
<br>
No, the flac code will not be "littered with code that's not necessary<br>
on the primary platforms".<br>
<br>
There will be some windows specific code in a new file, a bunch of<br>
replacements of existing fopen() calls with flac_fopen() (similarly<br>
for chmod and utime) and the main function for the flac and metaflac<br>
executables will have an additional:<br>
<br>
#ifdef _WIN32<br>
if (!convert_argv_to_utf8(&argc, &argv))<br>
flac__utils_printf(stderr, 1, "ERROR: yada yada\n");<br>
#endif<br>
<br>
This is a small un-obtrusive change that I fully support.<br>
<br>
I would however like to see it sooner rather than later so we can get<br>
this damn thing released :-).<br>
<br>
Erik<br>
--<br>
----------------------------------------------------------------------<br>
Erik de Castro Lopo<br>
<a href="http://www.mega-nerd.com/" target="_blank">http://www.mega-nerd.com/</a><br>
<br>
<br><br>---------- Forwarded message ----------<br>From: JonY <<a href="mailto:10walls@gmail.com">10walls@gmail.com</a>><br>To: <a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>Cc: <br>Date: Mon, 18 Mar 2013 17:35:14 +0800<br>
Subject: Re: [flac-dev] Patch to add Unicode filename support for win32 flac<br>On 3/18/2013 14:55, Erik de Castro Lopo wrote:<br>
> Brian Willoughby wrote:<br>
><br>
>> I believe that shell does handle wildcards on all Unix variants,<br>
>> including OSX.<br>
><br>
> Yes.<br>
><br>
>> Since Windows does not handle them, I suggest that the<br>
>> main flac code not be littered with code that's not necessary on the<br>
>> primary platforms.<br>
><br>
> No, the flac code will not be "littered with code that's not necessary<br>
> on the primary platforms".<br>
><br>
> There will be some windows specific code in a new file, a bunch of<br>
> replacements of existing fopen() calls with flac_fopen() (similarly<br>
> for chmod and utime) and the main function for the flac and metaflac<br>
> executables will have an additional:<br>
><br>
> #ifdef _WIN32<br>
> if (!convert_argv_to_utf8(&argc, &argv))<br>
> flac__utils_printf(stderr, 1, "ERROR: yada yada\n");<br>
> #endif<br>
><br>
> This is a small un-obtrusive change that I fully support.<br>
><br>
> I would however like to see it sooner rather than later so we can get<br>
> this damn thing released :-).<br>
><br>
<br>
Before anyone does anything, see __wgetmainargs<br>
<<a href="http://msdn.microsoft.com/en-us/library/ff770599.aspx" target="_blank">http://msdn.microsoft.com/en-us/library/ff770599.aspx</a>>.<br>
<br>
It can expand wildcards. Since it already provides argc/argv/env, it is<br>
more a less a drop-in replacement for the main() arguments.<br>
<br>
<br>
<br>_______________________________________________<br>
flac-dev mailing list<br>
<a href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>
<a href="http://lists.xiph.org/mailman/listinfo/flac-dev" target="_blank">http://lists.xiph.org/mailman/listinfo/flac-dev</a><br>
<br></blockquote></div><br></div>