[flac-dev] Updated MSVC patch

Ben Allison benski at winamp.com
Wed Mar 6 08:53:46 PST 2013


Thanks, Erik.

This is the delta that should fix everything up.
I hope that #include "share/compat.h" is acceptable from the test_streams
binary.  If not, you can probably change it to FLAC/ordinals.h instead

Also don't forget to commit my earlier VERSION="1.3.0" patch.  You can add
the "pre1" in a normal text editor without risk.  I didn't include those
changes in the big patch you committed already.
-Ben

> Ben Allison wrote:
>
>> Erik, et al.
>>
>> This fixes the entire library and does it more cleanly.  It puts most of
>> the guts into share/compat.h
>
> Thanks Ben.
>
> I applied a slightly tweaked version of the patch. The patch had to be
> tweaked because it broke the Linux build :-). Specifically, the file
> include/FLAC/ordinals.h is a public header file and should not include
> the project internal header "share/compat.h". I also moved some of the
> #ifdef stuff to "share/compat.h".
>
> What is in git now may not build on windows but should be really, really
> close. I'd appreciate it if you could test it and report the error
> messages. It might take a couple of iterations but we should get it
> working for all the platforms.
>
> Cheers,
> Erik
> --
> ----------------------------------------------------------------------
> Erik de Castro Lopo
> http://www.mega-nerd.com/
> _______________________________________________
> flac-dev mailing list
> flac-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FLAC-1-3-0-MSVC-round-two.patch
Type: application/octet-stream
Size: 1472 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130306/554b4c80/attachment.obj 


More information about the flac-dev mailing list