[PATCH] Add set -x to stop test_metaflac.sh

Martijn van Beurden mvanb1 at gmail.com
Thu Apr 25 06:20:23 PDT 2013


test_metaflac.sh wasn't aborting when replaygain values were
incorrect because the die() function was embedded in a pipe.
set -x was added so the script exits with a non-zero exit code
when die is called in a pipe.
---
 test/test_metaflac.sh |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/test_metaflac.sh b/test/test_metaflac.sh
index 9a13291..2ea2251 100755
--- a/test/test_metaflac.sh
+++ b/test/test_metaflac.sh
@@ -452,6 +452,8 @@ REPLAYGAIN_FREQ="$REPLAYGAIN_FREQ 37800/-14.18"
 REPLAYGAIN_FREQ="$REPLAYGAIN_FREQ 44100/-14.17"
 REPLAYGAIN_FREQ="$REPLAYGAIN_FREQ 48000/-14.16:1:2:4"
 
+set -x
+
 for ACTION in $REPLAYGAIN_FREQ ; do
   if [ -n "${ACTION##*:*}" ] ; then
     HARMONICS=1
-- 
1.7.10.4


--------------000406020203070807010202--


More information about the flac-dev mailing list