[flac-dev] [GIT PULL] Assorted bugfixes and improvements (from openSUSE)

Cristian Rodríguez crrodriguez at opensuse.org
Fri Mar 30 06:04:31 PDT 2012


El 30/03/12 07:14, Erik de Castro Lopo escribió:

>   * 7077ba8be2.. Use a single source-code wide definition of min() and max()
>
>     I like the idea of this commit but don't understand why it modifies
>     configure.ac. I also don't think the FLAC_SAFE_MIN/MAX defintions
>     belong in the file include/FLAC/export.h which is a public header file.
>     Instead, this definition belongs in one of the private/internal header
>     files.

Yes, I didnt find the right header ;)

>
>   * 8f05d0114c.. Support symbol visibility features present in GCC>  4
>
>     Again I like the idea of this patch, but I had in mind a solution to
>     this problem which will work for a number of compilers other than just
>     GCC.

The current version will work with clang, icc and gcc those define 
__GNUC__ and accept the -fvisibility-hidden flag




More information about the flac-dev mailing list