[flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
earl_chew at yahoo.com
Thu Apr 26 15:12:52 PDT 2012
I see my name is mentioned in passing ;-)
I submitted that patch because I thought it preferable to keep the test harness running.
Backing this change out would also entail changing metaflac_test.sh accordingly, which at the time, I was hesitant to do.
At the time I figured that at some point metaflac_test.sh was passing, so the code should probably allow it to pass.
I'm ok either way.
From: Josh Coalson <xflac at yahoo.com>
To: "flac-dev at xiph.org" <flac-dev at xiph.org>
Sent: Wednesday, April 25, 2012 3:23:35 PM
Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
I haven't checked git yet but I hope this patch has not gone in. I don't like the special case that this is creating.
It would be better to allow MM:SS everywhere but I consider that low priority.
> From: Earl Chew <earl_chew at yahoo.com>
>To: "flac-dev at xiph.org" <flac-dev at xiph.org>
>Sent: Thursday, January 5, 2012 8:27 PM
>Subject: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to completion
>When reading the INDEX from the cue sheet, the format MM:SS:FF format is disallowed if the sample frequency is not a multiple of 75 because the index would only be approximate. However, 00:00:00 is _exact_ because it denotes the start of the track, so allow it as a special case. This allows metaflac_test.sh to pass.
>flac-dev mailing list
>flac-dev at xiph.org
flac-dev mailing list
flac-dev at xiph.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the flac-dev