[flac-dev] [Flac-dev] Git branch with compiling fixes for win32

[Josh Coalson]

(Jumping in again, maybe at the wrong point since this doesn't seem to involve encoding, but here goes.)

Miroslav's patches have always been high-quality for sure.  But regardless of submitter, any patch that affects encoding must be reviewed very carefully, preferably by several other people and definitely me.  If there were ever a libFLAC release that had a bug and was not always lossless, that would be very damaging to the format.


Miroslav, sorry for dropping the ball on your patches; if I wasn't able to review properly then I didn't put it in, just out of caution.  Somewhere in my mailbox they're still there waiting to be looked at :)   Also, please keep an eye if you can on critical commits because you always were a good reviewer too.




>________________________________
> From: Erik de Castro Lopo <mle+la at mega-nerd.com>
>To: flac-dev at xiph.org 
>Sent: Friday, February 10, 2012 1:39 AM
>Subject: Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32
> 
>Miroslav Lichvar wrote:
>
>> I'd like to see the following patch included. It's not trivial, but I
>> think it's very well tested after those years.
>> http://www.mail-archive.com/flac-dev@xiph.org/msg00914.html
>> 
>> An updated version of the patch which includes some other
>> optimizations is here.
>> http://pkgs.fedoraproject.org/gitweb/?p=flac.git;a=tree
>
>I've had a look at that, but it doesn't apply to current git
>head and I'd like to have a bit of an explanation of what it
>does and why.
>
>> There are other patches which I think you might find useful: -asm,
>> -gcc43 and -hidesyms.
>
>Likewise for those.
>
>> I can prepare proper git patches, if interested.
>
>Patch with an explanation of what and why would be awesome.
>
>Current git head is here:
>
>    https://git.xiph.org/?p=flac.git;a=summary
>
>Cheers,
>Erik
>-- 
>----------------------------------------------------------------------
>Erik de Castro Lopo
>http://www.mega-nerd.com/
>_______________________________________________
>flac-dev mailing list
>flac-dev at xiph.org
>http://lists.xiph.org/mailman/listinfo/flac-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20120425/2bdaea8c/attachment-0001.htm