<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>(Jumping in again, maybe at the wrong point since this doesn't seem to involve encoding, but here goes.)</span></div><div><span><br></span></div><div><span>Miroslav's patches have always been high-quality for sure. But regardless of submitter, any patch that affects encoding must be reviewed very carefully, preferably by several other people and definitely me. If there were ever a libFLAC release that had a bug and was not always lossless, that would be very damaging to the format.<br></span></div><div><br><span></span></div><div>Miroslav, sorry for dropping the ball on your patches; if I wasn't able to review properly then I didn't put it in, just out of caution. Somewhere in my mailbox they're still there waiting to be looked at :) Also, please keep an eye if you can on critical commits
because you always were a good reviewer too.<span><br></span></div><div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Erik de Castro Lopo <mle+la@mega-nerd.com><br> <b><span style="font-weight: bold;">To:</span></b> flac-dev@xiph.org <br> <b><span style="font-weight: bold;">Sent:</span></b> Friday, February 10, 2012 1:39 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [flac-dev] [Flac-dev] Git branch with compiling fixes for win32<br> </font> </div> <br>
Miroslav Lichvar wrote:<br><br>> I'd like to see the following patch included. It's not trivial, but I<br>> think it's very well tested after those years.<br>> http://www.mail-archive.com/flac-dev@xiph.org/msg00914.html<br>> <br>> An updated version of the patch which includes some other<br>> optimizations is here.<br>> http://pkgs.fedoraproject.org/gitweb/?p=flac.git;a=tree<br><br>I've had a look at that, but it doesn't apply to current git<br>head and I'd like to have a bit of an explanation of what it<br>does and why.<br><br>> There are other patches which I think you might find useful: -asm,<br>> -gcc43 and -hidesyms.<br><br>Likewise for those.<br><br>> I can prepare proper git patches, if interested.<br><br>Patch with an explanation of what and why would be awesome.<br><br>Current git head is here:<br><br> <a href="https://git.xiph.org/?p=flac.git;a=summary"
target="_blank">https://git.xiph.org/?p=flac.git;a=summary</a><br><br>Cheers,<br>Erik<br>-- <br>----------------------------------------------------------------------<br>Erik de Castro Lopo<br>http://www.mega-nerd.com/<br>_______________________________________________<br>flac-dev mailing list<br><a ymailto="mailto:flac-dev@xiph.org" href="mailto:flac-dev@xiph.org">flac-dev@xiph.org</a><br>http://lists.xiph.org/mailman/listinfo/flac-dev<br><br><br> </div> </div> </blockquote></div> </div></body></html>