[Flac-dev] PATCH : Fix missing protoypes

Erik de Castro Lopo erikd-flac at mega-nerd.com
Wed Jul 25 02:10:17 PDT 2007


Erik de Castro Lopo wrote:

> I can play with this over the weekend if you like and come up
> with a new patch for configure.ac.

Here's a much cleaner patch which only adds -Wmissing-prototypes 
and -Wstrict-prototypes to CFLAGS, not to CXXFLAGS.

Cheers,
Erik

--------------------8<--------------------8<--------------------
diff -u -r1.144 configure.in
--- configure.in        7 Jul 2007 06:10:35 -0000       1.144
+++ configure.in        25 Jul 2007 09:08:00 -0000
@@ -281,9 +281,10 @@
        OUR_CFLAGS_HEAD="$OUR_CFLAGS_HEAD -DNDEBUG"
        if test "x$GCC" = xyes; then
                OUR_CFLAGS_HEAD="$OUR_CFLAGS_HEAD -O3 -funroll-loops -finline-functions -Wall -W -Winline -DFLaC__INLINE=__inline__"
+               OUR_C_ONLY_CFLAGS="-Wmissing-prototypes -Wstrict-prototypes"
        fi
 fi
-CFLAGS="$OUR_CFLAGS_HEAD $CFLAGS"
+CFLAGS="$OUR_CFLAGS_HEAD $OUR_C_ONLY_CFLAGS $CFLAGS"
 CXXFLAGS="$OUR_CFLAGS_HEAD $CXXFLAGS"
 
 #@@@
--------------------8<--------------------8<--------------------

-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
Percussive Maintenance: The fine art of whacking the c**p out
of an electronic device to get it to work again.


More information about the Flac-dev mailing list