[Flac-dev] PATCH : Fix missing protoypes

Erik de Castro Lopo erikd-flac at mega-nerd.com
Tue Jul 24 20:19:57 PDT 2007


Josh Coalson wrote:

> --- Erik de Castro Lopo <erikd-flac at mega-nerd.com> wrote:
> 
> > Hi all,
> > 
> > I added -Wmissing-prototypes -Wstrict-prototypes to the CFLAGS and
> > found that there were a number warnings generated.
> > 
> > The patch below fixes those warnings and adds the two -W flags to
> > configure.in.
> 
> I checked most of it in, though g++ 4.0.0 is giving me:

Hmm, maybe I blew it.

Basically CFLAGS and CXXFLAGS should be kept separate and and CFLAGS
should have "-Wmissing-prototypes -Wstrict-prototypes" and CXXFLAGS
shouldn't.

I can play with this over the weekend if you like and come up
with a new patch for configure.ac.

Erik
-- 
-----------------------------------------------------------------
Erik de Castro Lopo
-----------------------------------------------------------------
The government everybody loves to abuse sues the company everybody loves
to hate. Throw in a bunch of faceless lawyers cross-examining techies
[with] all the charisma of a video driver and you've got a spectacle of
thoroughly miniscule proportions.


More information about the Flac-dev mailing list