[Flac-dev] ordinals.h in beta1

Kernel Jake kerneljake at hotmail.com
Sun Aug 1 12:49:07 PDT 2004


I think ordinals.h needs to be generated as system-specific instead of 
hardcoded.

The HAVE_INTTYPES_H stanza below is problematic:

#ifdef HAVE_CONFIG_H
#include <config.h>
#endif

#ifdef HAVE_INTTYPES_H
#include <inttypes.h>
#elif defined(HAVE_U_INT)
#ifdef HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#define uint8_t u_int8_t
#define uint16_t u_int16_t
#define uint32_t u_int32_t
#define uint64_t u_int64_t
#elif !defined(_MSC_VER)
#error Unable to find fixed-size data types
#endif

The autoconf directives HAVE_CONFIG_H and HAVE_INTTYPES_H have no meaning to 
3rd party apps that #include <FLAC/all.h>.  flac123 fails to compile on 
Redhat 9.0 unless I hack ordinals.h to #include <inttypes.h>.

In flac 1.1.0, ordinals.h was generated from ordinals.h.in by config.status. 
  In flac 1.1.1, ordinals.h is hardcoded.  I contend that the above two 
stanzas should be interpreted at 'configure'-time so that the resulting 
ordinals.h yields the stanza as

#include <inttypes.h>

... on a system whose 'configure' found <inttypes.h>.

_________________________________________________________________
Planning a family vacation? Check out the MSN Family Travel guide! 
http://dollar.msn.com





More information about the Flac-dev mailing list