[Flac-dev] XMMS plugin build fix

[Josh Coalson]

Damn, back to this thread:

> I think I sent a bad patch for this one already, which used a _LIBS
> variable.
> There is no _LIBS variable. :-)  So, the .la file should be specified
> directly
> in _LIBADD, with no linker flag syntax.  libtool will figure it out.
> 
> diff -u -r1.1.1.1 Makefile.am
> --- Makefile.am 29 Jan 2001 18:13:29 -0000      1.1.1.1
> +++ Makefile.am 21 Jun 2001 19:27:31 -0000
> @@ -9,5 +9,5 @@
>  
>  xmmsinputplugin_LTLIBRARIES = libxmms-flac.la
>  libxmms_flac_la_SOURCES = plugin.c
> -libxmms_flac_la_LIBADD = -L$(top_builddir)/src/libFLAC/.libs -lFLAC
> @XMMS_LIBS@
> +libxmms_flac_la_LIBADD = @XMMS_LIBS@
> $(top_builddir)/src/libFLAC/libFLAC.la
>  libxmms_flac_la_LDFLAGS = -module -avoid-version

now when I build the xmms plugin, upon linking I get:

../../libtool-disable-static --mode=link gcc  -I./include -I
../../include -Wall -W -O3 -DNDEBUG -fomit-frame-pointer -funroll-loops
-finline-functions -Winline -DFLaC__INLINE=__inline__ -g -O2
-I/usr/include/xmms -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2
-I/usr/lib/glib/include -D_REENTRANT -I/usr/X11R6/include  -o
libxmms-flac.la -rpath /usr/lib/xmms/Input -module -avoid-version
plugin.lo -L/usr/lib -L/usr/X11R6/lib -lgtk -lgdk -rdynamic -lgmodule
-lgthread -lglib -lpthread -ldl -lXi -lXext -lX11 -lm -lxmms
../../src/libFLAC/libFLAC.la
libtool-disable-static: link: error: cannot link shared libraries into
libtool libraries

where if I revert to the old _LIBADD line things work fine.

Also, if I try and force -static like so:

libxmms_flac_la_LIBADD = -static @XMMS_LIBS@
$(top_builddir)/src/libFLAC/libFLAC.la

libtool complains "you cannot use linker flags such as
`-static' in `libxmms_flac_la_LIBADD'.  But if I leave
-static out of Makefile.am and jam it in to the generated
Makefile, it links fine.

At this point I'm not sure what should go in there, not
being much of a libtool guy.

Josh


__________________________________________________
Do You Yahoo!?
Get personalized email addresses from Yahoo! Mail
http://personal.mail.yahoo.com/