[daala] Fixing problem with shadowed variables

Danesh Daroui danesh.daroui at gmail.com
Sat Apr 25 00:20:40 PDT 2015

Thanks for the feedback. Here comes a new patch attached. Hope that it is



On Sat, Apr 25, 2015 at 8:30 AM, Timothy B. Terriberry <tterribe at xiph.org>

> Danesh Daroui wrote:
> > -          unsigned w;
> > +          unsigned local_w;
> I would recommend using a (slightly) less confusing name like "window".
> You should also change the corresponding lines in the horizontal loop
> above, e.g.,
>            w=hkernel[k];
> etc. Since the code is meant to follow the same pattern in both places,
> it would be helpful if it used the same variable names.
> _______________________________________________
> daala mailing list
> daala at xiph.org
> http://lists.xiph.org/mailman/listinfo/daala
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.xiph.org/pipermail/daala/attachments/20150425/290107df/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Changed-the-name-of-the-shadowed-variables-to-someth.patch
Type: text/x-patch
Size: 2052 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/daala/attachments/20150425/290107df/attachment-0001.bin 

More information about the daala mailing list