[daala] Fixing problem with shadowed variables

Timothy B. Terriberry tterribe at xiph.org
Fri Apr 24 23:30:30 PDT 2015


Danesh Daroui wrote:
> -          unsigned w;
> +          unsigned local_w;

I would recommend using a (slightly) less confusing name like "window". 
You should also change the corresponding lines in the horizontal loop 
above, e.g.,

           w=hkernel[k];

etc. Since the code is meant to follow the same pattern in both places, 
it would be helpful if it used the same variable names.


More information about the daala mailing list