[xiph-rtp] linphone-1.5.0 mostly complies to theora over RTP draft

[Simon Morlat]

Hello Luca,

> > It's in file mediastreamer2/src/theora.c for those who are curious.
> > - it uses the packed conf technique (which I still found the easiest and
> > more flexible way in a SIP/SDP context )
>
> Make sure you also inline the first conf in the sdp...
Why ? Is this required ?

>
> I'm reading rfc3984 to pick parameters and parameters name in a way that
> matches other rfcs, if you could have a look too and tell me which
> parameters could be useful in your fields, I'll try to avoid ones that
> don't make sense. The O/A section seems interesting too.
rfc2984 has an extensive set of parameter that I don't find very useful...
I don't think they will be used by many people around the earth.
I suggested a 'maxframes' parameter to handle the case of an application like 
linphone that never sends multiple frames in a single RTP packet and thus 
does not want to support it at the receiving side, however this is not a good 
idea. There may be the case where linphone will call a SIP server that 
broadcast TV or whatever, so the case of multiples frames into one packet can 
produce on a SIP phone.
I'd rather implement the multiple frames decoding algorithm into linphone, and 
keep the draft as simple as possible.
Parameters such as max_br are redundant with already existing b=AS or b=TI SDP 
parameters.
Some other parameters indicate the maximum decoding capabilities of a receiver 
(max frames per seconds, max size, max macroblocks per second and so on), 
those ones might be interesting for small embedded devices that may be 
limited processing or display capabilities. I would prefer having them common 
to all video codecs, but it does not seem to be the way things are going.
So I think it's up to you to decide such paremeters to theora draft, but I at 
least recommend you to keep them:
- optionnal
- as receiver options (to allow asymetric operations)

Simon


>
> Let me know, hopefully I'll commit an update soon.
>
> lu