[Vorbis] Antw: [PATCH] opus support for ogg123

[Mario Blättermann]

Am 07.05.2014 13:28, schrieb Jeff Muizelaar:
> 
> On May 7, 2014, at 2:03 AM, Ulrich Windl <Ulrich.Windl at rz.uni-regensburg.de> wrote:
> 
>> Hi!
>>
>> Just my opinion: The name ogg123 is not very fortunate as it actually is about
>> Vorbis.
> 
See below. The name is OK so far because Ogg is a container format, and it
supports more than just the Vorbis codec.

> ogg123 doesn’t really have much to do with vorbis other than being in the vorbis-tools
> package. Vorbis support is implemented on top of the vorbisfile api similar to how
> this patch adds support for opus using opusfile.
> 
>> Piggybacking Opus on it won't make it better.
>> So is there a lot of common code between Vorbis and Opus, or what is the
>> reason for not provising a separate tool like opus123?
> 
> ogg123 already provides support for playback of speex and flac, it seems a reasonable
> extension to also have support for opus.
> 
I agree here. Well, the man page says "plays ogg vorbis files", but the name is
ogg123 which doesn't say anything about vorbis. Ogg123 can already handle Speex
and Flac anyway, so it would be fine if it supports Opus, too.

By the way, the man page needs to be updated to reflect the additional
abilities. Something like "- plays sound files in various formats" in the
header, and "Supported formats are:" would be sufficient.

Best Regards,
Mario