<div dir="ltr">Hello All,<div><br></div><div>Please note that I haven't abandoned my patchset.. I am hoping the brains in opus will review my code and accept it there. Just posted yesterday. You can find it at [1] and [2].</div><div><br></div><div>Then, I can just redo my Vorbis neon patches accordingly and resubmit here.. but expecting this will take some time.<br></div><div><br></div><div>[1]: <a href="http://lists.xiph.org/pipermail/opus/2014-November/002745.html">http://lists.xiph.org/pipermail/opus/2014-November/002745.html</a></div><div>[2]: <a href="http://lists.xiph.org/pipermail/opus/2014-November/002744.html">http://lists.xiph.org/pipermail/opus/2014-November/002744.html</a></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><font face="comic sans ms, sans-serif">Regards,</font><div><font face="comic sans ms, sans-serif">Vish (Viswanath Puttagunta)</font></div></div></div></div>
<br><div class="gmail_quote">On 2 October 2014 23:38, Chris Moore <span dir="ltr"><<a href="mailto:moore@free.fr" target="_blank">moore@free.fr</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Vish,<br>
<br>
I am very interested in your Vorbis optimisations.<br>
Unfortunately I am not a NEON guru, nor even an ARM assembler one.<br>
I had a quick look at your code and the only remark I have concerns the pseudo-code in comments.<br>
In several places you write:<br>
a[i] = a[i]*b[n-i-1] + a[i]*c[i]<br>
but IMHO this should be:<br>
a[i] = a[i]*b[n-i-1] + b[i]*c[i]<br>
<br>
I have also done some work on Vorbis improvements, mainly to Tremor.<br>
I posted some information on them to this list early this year, mainly in March.<br>
Unfortunately nobody showed any interest in receiving patches :(<br>
I shall be interested to see if anybody integrates yours.<br>
Maybe we should be working on Opus ;-)<br>
<br>
I am afraid that I have not tested your modifications.<br>
For the moment I have been working on pure C code in the comfort of an x86_64 environment.<br>
But I have oldish ARM hardware in mind as Tremor is really for architectures without hardware floating point.<br>
<br>
Cheers,<br>
Chris<br>
<br>
Le 01/10/2014 20:33, Viswanath Puttagunta a écrit :<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div><div class="h5">
<br>
On 1 October 2014 12:35, Ralph Giles <<a href="mailto:giles@thaumas.net" target="_blank">giles@thaumas.net</a> <mailto:<a href="mailto:giles@thaumas.net" target="_blank">giles@thaumas.net</a>>> wrote:<br>
<br>
On 2014-10-01 10:00 AM, Viswanath Puttagunta wrote:<br>
<br>
> I would like to get feedback on "1" above from this list. I first<br>
want<br>
> to make sure the modifications to autoconf files is in line with the<br>
> project.<br>
<br>
Not having looked at the patches, you should compare your work<br>
with the<br>
instruction set detection in the opus implementation. That has worked<br>
well so far, if you can say you did the same thing, it will be easier<br>
for the authors to review it.<br>
<br>
<a href="https://git.xiph.org/?p=opus.git;a=summary" target="_blank">https://git.xiph.org/?p=opus.<u></u>git;a=summary</a><br>
<br>
>> Thanks, will do.<br>
<br>
<br>
<br>
> For "2", which is ARM NEON specific reviews, if necessary, I can<br>
ping a<br>
> few of ARM's NEON gurus and I think they will be happy to join<br>
this list<br>
> and review the code.<br>
<br>
Do you have output verification and benchmark results you can share?<br>
<br></div></div>
>> As mentioned in cover letter for patches, available here <<a href="https://docs.google.com/a/vishndivi.com/document/d/1LuMORT2jIroiuDKAQaj7YpizCRQBpgruC8DKDlzc8ik/edit" target="_blank">https://docs.google.com/a/<u></u>vishndivi.com/document/d/<u></u>1LuMORT2jIroiuDKAQaj7YpizCRQBp<u></u>gruC8DKDlzc8ik/edit</a>>. <br>
<br>
<br>
-r<span class=""><br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
Vorbis-dev mailing list<br>
<a href="mailto:Vorbis-dev@xiph.org" target="_blank">Vorbis-dev@xiph.org</a><br>
<a href="http://lists.xiph.org/mailman/listinfo/vorbis-dev" target="_blank">http://lists.xiph.org/mailman/<u></u>listinfo/vorbis-dev</a><br>
</span></blockquote>
<br>
</blockquote></div><br></div></div>