<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On 1 October 2014 12:35, Ralph Giles <span dir="ltr"><<a href="mailto:giles@thaumas.net" target="_blank">giles@thaumas.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 2014-10-01 10:00 AM, Viswanath Puttagunta wrote:<br>
<br>
> I would like to get feedback on "1" above from this list. I first want<br>
> to make sure the modifications to autoconf files is in line with the<br>
> project.<br>
<br>
</span>Not having looked at the patches, you should compare your work with the<br>
instruction set detection in the opus implementation. That has worked<br>
well so far, if you can say you did the same thing, it will be easier<br>
for the authors to review it.<br>
<br>
<a href="https://git.xiph.org/?p=opus.git;a=summary" target="_blank">https://git.xiph.org/?p=opus.git;a=summary</a></blockquote><div> >> Thanks, will do. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<span class=""><br>
> For "2", which is ARM NEON specific reviews, if necessary, I can ping a<br>
> few of ARM's NEON gurus and I think they will be happy to join this list<br>
> and review the code.<br>
<br>
</span>Do you have output verification and benchmark results you can share?<br></blockquote><div>>> As mentioned in cover letter for patches, available <a href="https://docs.google.com/a/vishndivi.com/document/d/1LuMORT2jIroiuDKAQaj7YpizCRQBpgruC8DKDlzc8ik/edit">here</a>. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
-r<br>
<br>
</font></span></blockquote></div><br></div></div>