[Vorbis-dev] [PATCH] vcut - Fix cut failure with discarded output

Michael Gold mgold at ncf.ca
Sat May 19 09:04:58 PDT 2012


Hi all,

Here's a patch to fix a spurious failure in vcut.  Please apply.

If the user wants to drop the output (i.e. the filename is given as ".")
and the cutpoint is found before open_output_file is called, drop_output
will not have been set, and vcut will fail with the error "Can't produce
a file starting and ending between sample positions [...]".  But when no
output file is desired, we can safely ignore this condition.

This changes the code to call the new function will_drop_output, instead
of reading s->drop_output.  This function checks the filename as well as
s->drop_output.

-- Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vcut-first-packet.diff
Type: text/x-diff
Size: 1652 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20120519/5abe6dd3/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20120519/5abe6dd3/attachment.pgp 


More information about the Vorbis-dev mailing list