[Vorbis-dev] Tremor maintenance

[Stefan Kost]

hi,

Conrad Parker wrote:
> On 21 April 2010 17:51, Stefan Kost <ensonic at hora-obscura.de> wrote:
>   
>> Hi,
>>
>> Conrad Parker wrote:
>>     
>>> On 20 April 2010 17:16, Stefan Kost <ensonic at hora-obscura.de> wrote:
>>>
>>>       
>>>> Conrad Parker wrote:
>>>>
>>>>         
>>>>> On 20 April 2010 15:45, Stefan Kost <ensonic at hora-obscura.de> wrote:
>>>>>
>>>>>
>>>>>           
>>>>>> hi,
>>>>>>
>>>>>> could someone please apply these to Tremor svn?
>>>>>>
>>>>>> 0001-update_symbols.patch
>>>>>> there are 3 public symbols in the headers, which are missing in the
>>>>>> linker script and thus marked as private again. This causes issues for
>>>>>> e.g. gstreamer (https://bugzilla.gnome.org/show_bug.cgi?id=616194).
>>>>>>
>>>>>> 0002-pkgconfig.patch
>>>>>> this adds a pkg config file
>>>>>>
>>>>>>
>>>>>>
>>>>>>             
>>>>> Hi,
>>>>>
>>>>> I tested and applied these two patches.
>>>>>
>>>>> (Apologies that your attribution didn't stay with the commit -- I set
>>>>> you as the author using git-svn, but subversion turned it into a
>>>>> normal svn commit and rewrote the author info).
>>>>>
>>>>>
>>>>>           
>>>> Thanks for your quick action! Here is one more that dists the html docs
>>>> and the win32 build filed as well.
>>>>
>>>>         
>>> ok, I've applied this to trunk/Tremor.
>>>
>>> I've also merged the relevant parts of these patches into
>>> branches/lowmem-branch/ (without the Win32 bits)
>>> and branches/lowmem-no-byte/ (without the Version_script, doc or Win32
>>> bits as they don't exist on that branch).
>>>
>>> Conrad.
>>>
>>>       
>> sorry, the filter script needed more entries, so that ivorbisdec is api
>> compatible with normal vorbisdec.
>> Also attached another patch that fixes the
>>
>> configure: WARNING: unrecognized options: --enable-maintainer-mode
>>
>> at the end of configure run when one was using autogen.sh. If you don't
>> like maintainer mode, then I'd suggest to remove
>> "--enable-maintainer-mode" from the last line in autogen.sh instead.
>>     
>
> I've applied both of these to trunk/Tremor (r17156,r17157), and also
> to branches/lowmem-branch. I've applied the second to
> branches/lowmem-no-byte (the first doesn't apply as that branch has no
> Version_script.in).
>
> Thoughts
> 	* Stefan should get svn access
>
> 	* The tremor branches aren't quite in sync, ie. don't have the same
> build options, Win32 files, symbol files etc.
>
> It would be useful to unify these somehow, but that seems a bit
> difficult with the current svn structure. Assuming we want
> to stick with svn for Tremor, and svn recently has better merging
> capabilities than it did a few years ago (svn mergeinfo
> etc.), would it makes sense to move the Tremor sources to a more
> conventional structure like:
>
> http://svn.xiph.org/Tremor/trunk
> http://svn.xiph.org/Tremor/branches/lowmem
> http://svn.xiph.org/Tremor/branches/lowmem-no-byte
>
> so that a single checkout could make a tree with all the Tremor
> trunk+branches, and tools that understand the conventional
> layout would work more simply?
>   
I haven't done a many (successful) svn merges, but I will look how
different the branches are. I think it would be beneficial if the
different variants would live in one source tree and one could use
configure to select the desired variant.

Stefan

> cheers,
>
> Conrad.
>