[Vorbis-dev] Re: vorbis-tools 1.2.0 Release Candidate

[Conrad Parker]

On 22/02/2008, ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at googlemail.com> wrote:
>  Ivo wrote:
>  > Seriously now, was it not working for you until you changed "len" to
>  > long? Or was that change to fix a warning?
>
> It was working fine, but I reckon it wouldn't have worked on a machine
>  where sizeof(long)>sizeof(int).
>
>  I apologize in advance if I'm having the wrong end of the stick here.
>  Maybe it's not a problem and I'm just very confused.

Mixing up long and int is definitely a problem. Even if it didn't
cause any errors with this code currently, it could lead to errors
down the track (like the errors worked around in the latest liboggz
release, root cause being that libogg mixes up int and long for
serialno values).

We should definitely make sure to remove all compile warnings :-)

Conrad.