[Vorbis-dev] [PATCH] vorbis-tools, various

[Conrad Parker]

On 15/02/2008, Ivo Emanuel Gonçalves <justivo at gmail.com> wrote:
> Regarding your libvorbis issue, can you check later what version you
>  have?  vorbis-tools requires the bare minimum of version 1.1.1.  That
>  is highly deprecated by now, and to commit all those ifdefs merely for
>  the people running a possibly even older version of libvorbis than
>  1.1.1 seems unwise.

Seems straightforward to me. Whether or not a project considers older
versions "deprecated" is irrelevent, the fact is they exist and this
code compiles against them with the trivial patches supplied.

>  Your libcurl issue I do not understand.  Do you really need another
>  check for curl to be able to compile the tools?

It allows for the case where the system pkg-config exists, but the
installed libcurl has not installed a pkg-config file.

I had a brief look over those patches, they look ok to me. It may make
sense to hold off on the Kate support for 1.2.0 as you suggested, as
that is experimental; and you probably want to simply remove the
printf in the last hunk.

Conrad.