[Vorbis-dev] [PATCH] vorbis-tools, various

ogg.k.ogg.k at googlemail.com ogg.k.ogg.k at googlemail.com
Thu Feb 14 02:32:38 PST 2008


Hi,

I've just downloaded vorbis-tools-1.2.0-RC4.tar.gz yesterday, and it
didn't build on
my machine, which, cunningly, has an old libvorbis.

The first two patches fix detection of libcurl (which is probably
rather old too), and
make oggenc build with my libvorbis. An old one, and I forgot to look
up its version,
and I'm not at home just now. It was before the advanced encoder options.

The third one adds kate support, if libkate's found, so you may or may
not decide to
apply it. That libkate API's stable though.

I noticed it afterwards, but the last hunk also fixes length check
bugs for a couple
magics, so you'll want this one.

Now, you want to have a look at the place that says "Look, without the
hands, ma",
because it's a place where I've taken out the advanced encoder stuff
to make it build,
but which I'm not sure should be replaced by something else for old
libvorbis. It seems
to encode fine for me, but YMMV, someone who knows well libvorbis should have a
look. It may be that it's fine as is, in which case just remove the printf.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools-configure.diff
Type: text/x-patch
Size: 534 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080214/88690cda/vorbis-tools-configure.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools-kate.diff
Type: text/x-patch
Size: 14446 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080214/88690cda/vorbis-tools-kate.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vorbis-tools-old-libvorbis.diff
Type: text/x-patch
Size: 1920 bytes
Desc: not available
Url : http://lists.xiph.org/pipermail/vorbis-dev/attachments/20080214/88690cda/vorbis-tools-old-libvorbis.bin


More information about the Vorbis-dev mailing list