[Vorbis-dev] Re: vorbis-tools 1.2.0 Release Candidate

[Christian Weisgerber]

Ivo Emanuel Gonçalves <justivo at gmail.com> wrote:

> Third and hopefully final Release Candidate is out[1].

Why is vcut disabled by default?

The path of ogg123rc is still hard-coded to /etc.  This should
really be $(sysconfdir).

--- ogg123/Makefile.am.orig	Fri Mar 16 16:50:58 2007
+++ ogg123/Makefile.am	Fri Mar 16 16:52:04 2007
@@ -16,7 +16,7 @@ endif
 
 datadir = @datadir@
 localedir = $(datadir)/locale
-DEFS = -DLOCALEDIR=\"$(localedir)\" @DEFS@
+DEFS = -DSYSCONFDIR=\"$(sysconfdir)\" -DLOCALEDIR=\"$(localedir)\" @DEFS@
 
 docdir = $(datadir)/doc/$(PACKAGE)-$(VERSION)
 mandir = @MANDIR@
--- ogg123/cfgfile_options.c.orig	2003-09-30 02:15:22.000000000 +0200
+++ ogg123/cfgfile_options.c	2003-09-30 02:15:39.000000000 +0200
@@ -441,7 +441,7 @@ void parse_std_configs (file_option_t op
   char filename[FILENAME_MAX];
   char *homedir = getenv("HOME");
 
-  parse_config_file(opts, "/etc/ogg123rc");
+  parse_config_file(opts, SYSCONFDIR "/ogg123rc");
   if (homedir && strlen(homedir) < FILENAME_MAX - 10) {
     /* Try ~/.ogg123 */
     strncpy(filename, homedir, FILENAME_MAX);
-- 
Christian "naddy" Weisgerber                          naddy at mips.inka.de