[vorbis-dev] Some Questions

[Dominik Kuhlen]

Hello 
I posted these to the vorbis maillist, but got no answers,
so I try it here again:

Currently, I'm having a
very close look at the spec and discovered some mistakes,
misundestandings:

1---------

in "vorbis-spec-res.html"
paragraph
Residue format
 Reside format partitions each.........
        ^ heres the 'u' missing.

<p>2--------------

Probably another one in vorbis-spec-floor1.html
at paragraph :
        packet decode
6) [class] = vector [floor1_partition_class]  element [i]
                          ^^^^^^^^^^^^^^^^^^^
is floor1_partition_class correct ? or should it be 
        floor1_partition_class_list

<p>3---------------
According to "vorbis-spec-ref.html"
paragraph: "mappings", the vector [vorbis_mapping_mux] 
should contain the following:
4.
if [vorbis_mapping_submaps] is greater than one, we read channel multiplex settings. 
For each [j] of [audio_channels] channels:
        1. vector [vorbis_mapping_mux] element [j] = read 4 bits as unsigned integer
        2. if the value is greater than the highest numbered submap 
            ([vorbis_mapping_submaps] - 1), this in an error condition rendering the stream undecodable

But, what are the values of vector [vorbis_mapping_mux] 
if [vorbis_mapping_submaps] is not greater than one? 

4--------------------------
Same file:
paragraph: "packet type, mode and window decode"
8. for [i] in range [right_window_start] ... [right_window_end]-1, 
        window([i]) = sin(.5 * PI * sin^2( ([i]-[right_window_start]+.5) / [right_n] * .5 * PI/2. + .5 * PI) ) 
9. window from range [rigth_window_start] ... [n]-1 is zero 
                                   ^^^^^^^^^^^^^
This should be "right_window_end", otherwise it wouldn't make 
sense

5------------------------------
Again same file:
paragraph "floor curve decode"

 From this point on, we assume out decode context is using mode number
                                             ^^^
I think this should be "our" not "out".

6--------------------------------
File "vorbis-spec-ref.html"
paragraph "packet type, mode and window decode"

1. if this is a long window (the [vorbis_mode_blockflag] flag of this mode is set):
        1. read 1 bit for [previous_window_flag]
        2. read 1 bit for [next_window_flag]
...

But how to set/unset them if [vorbis_mode_blockflag] flag of this mode is not set?
(compiler complains about unitialized variables)

<p>Thank you
Dominik
--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.