[vorbis-dev] ogg123 remote interface

[Segher Boessenkool]

Just some comments on getting-rid-of-warnings:

> remove-globals.patch
>   remove the many global variables from ogg123.c

bad idea for ogg123, imho

> make-character-pointers-const.patch

useless.  makes no difference at all for generated code.  const in C does
not mean the same as const in C++.  it just clobbers up the code.

> remove-some-compiler-warnings.patch
>   Fixes for some compiler warnings. Unused variable buf commented out.

remove or don't remove, but don't comment out ;)

>   char * initialized to 0 instead of "".

that means something different -- i hope you checked it doesn't
actually matter

> remove-shadowed-variables.patch
>   Fix some places in the code where variables are "shadow"ed. These
>   show up as compiler warnings when compiling with -Wshadow.

bad idea, imnsho.

> buffer-code-cleanup.patch
>   Remove unused function free_action. Remove duplicate comment.

fine

> make-playlist-array-null-terminated.patch
>   Make the playlist NULL terminated. This prevents us from carrying around
>   the number of items in the playlist later on.

depends -- what about shuffling?  a single int isn't expensive, reading a list
_is_.

<p>Have fun,

Segher
--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.