[vorbis-dev] Adding RC3 support to GoldWave

[Segher Boessenkool]

Chris Craig wrote:
> 
> Here are some minor things I noticed when updating the vorbis module
> for GoldWave:
> 
> Bitwise.c, line 175 and 207

The file is called bitwise.c (no capital B).

> Warning: Negative unsigned value
>     ret=-1UL;

The constant is _not_ negative (-1 isn't part of the number token).
Yes, returning -1 as an unsigned is dirty.

> 
> Info.c, line 385
> Warning: Unreachable code
>     break;

Harmless.  Some other compilers warn _without_ it.  Removing it is nicer,
yes, imho.

> 
> vorbisfile.c, line 1407
> Warning: Call to function with no prototype
>   int host_endian = host_is_big_endian();
> fix: add 'void' to line 1339:
> static int host_is_big_endian( void ) {

That's a bug, yes.

> 
> time0.c, line 36, runtime error
> Access overrun (reported by Borland CodeGuard)
>   return "";

What's wrong with this?

<p>Segher

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.