[vorbis-dev] Adding RC3 support to GoldWave

[Chris Craig]

Here are some minor things I noticed when updating the vorbis module
for GoldWave:

Bitwise.c, line 175 and 207
Warning: Negative unsigned value
    ret=-1UL;

Info.c, line 385
Warning: Unreachable code
    break;

vorbisfile.c, line 1407
Warning: Call to function with no prototype
  int host_endian = host_is_big_endian();
fix: add 'void' to line 1339:
static int host_is_big_endian( void ) {

time0.c, line 36, runtime error
Access overrun (reported by Borland CodeGuard)
  return "";

One not so minor thing:

vorbis_encode_init() does not seem to be working correctly.  No matter
what bitrates are specified, the output file always seems to be 200+kbps.

vorbis_encode_init_vbr() creates smaller files (though the HTML API
document mentions bitrate settings).  However, there is currently no
ov_quality() function to determine the current quality setting to use
if someone opens, edits, then resaves a vorbis file.  Perhaps the vbr
quality to/from bitrate functions could be part of the API.

Chris
http://www.goldwave.com

<p>--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.