[vorbis-dev] More suggestions

[Ingo Ralf Blum]

Thanks for comitting my suggestions into the CVS. However there are some things
to mention:

1. There are still .%SRCROOT%==. constructs as well as many lines in the
makesdk.bat, which contain environment variables, but are not enclosed in
quotes, so builds fail on systems with spaces in the source path.

2. The include and lib directory assignments in the various bat files are of the
form

et INCLUDE=%INCLUDE%;%SRCROOT%\ogg\include

but I think that

et INCLUDE=%SRCROOT%\ogg\include;%INCLUDE%

is better in cases where the user has some old include files lying around. So
always the newest files are used. (The same for LIB)

3. There are still some references to c:\src\ in the bat files in LIB and
INCLUDE assignments.

4. And of course the PNG images are not binary.

Should I send a patch?

Regards Ingo

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.