[vorbis-dev] oggenc broken for some types of WAV files

[Michael Smith]

At 01:23 AM 7/28/01 -0700, you wrote:
>Hello,
>
>I have found that there are some WAV files which have a "fmt" chunk size greater
>then 16 bytes (length indicator greater then 16).  The patch is attached.
>
>What is the normal method for submiting patches?
>

The normal method is to send them to the list, as you've done.

Your patch is incorrect (will cause crashes if used). There's already a
special case for allowing the "fmt " chunk to be of length 18 - this is
incorrect according to every wav spec I've been able to find, but is 
common. However, allowing arbitrarily long fmt chunks is definately not
a good idea, so I won't be changing this behaviour unless you can show
me an official wav spec that says this is allowed. 

The application that is creating these files is presumably buggy.

Michael

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.