[vorbis-dev] Makefile.am patch

Jeff Squyres jsquyres at lsc.nd.edu
Sat Jan 20 05:54:37 PST 2001

Since vorbiscomment is being resurrected in a new form, can someone please
fix the vorbis-tools/vorbiscomment/Makefile.am?

There's two things wrong:

1. Using _LDFLAGS doesn't allow the user to specify their own LDFLAGS.
   _LDADD or _LIBS should be used instead.

2. The order of libraries is wrong such that it won't link properly when
   compiled statically.

Here's a trivial patch to fix that one line (from "cvs diff -c"):

Index: Makefile.am
RCS file: /usr/local/cvsroot/vorbis-tools/vorbiscomment/Makefile.am,v
retrieving revision 1.6
diff -c -r1.6 Makefile.am
*** Makefile.am	2001/01/19 11:39:23	1.6
--- Makefile.am	2001/01/20 13:52:55
*** 6,12 ****


! vorbiscomment_LDFLAGS = @OGG_LIBS@ @VORBIS_LIBS@
  vorbiscomment_SOURCES = vcedit.c vcedit.h vcomment.c

--- 6,12 ----


! vorbiscomment_LDADD = @VORBIS_LIBS@ @OGG_LIBS@
  vorbiscomment_SOURCES = vcedit.c vcedit.h vcomment.c


{+} Jeff Squyres
{+} squyres at cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.

More information about the Vorbis-dev mailing list