[vorbis-dev] fast math optimization patch

Michael Smith msmith at labyrinth.net.au
Sat Feb 10 17:07:38 PST 2001



At 02:00 PM 2/10/01 -0800, you wrote:
>
>
>   Has any one had a chance to look at the patch I sent for this 
>optimization?
>
>   Questions?  Comments?  Flames?

Looked mostly very good. Except that it defines the endianness for a couple
of platforms and lets the others sit there broken. Since the rest of
libvorbis is completely endian-neutral, this is a bit of a pain. Or maybe I
misread the code, and it just falls back to the old version when it's not
defined.

And it uses bitfields, which are chronically unportable when you want to
use them with any real meaning (C doesn't guarantee enough about them to
make them very useful)

Michael

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the Vorbis-dev mailing list