[vorbis-dev] ogg.m4 and vorbis.m4

[Jeff Squyres]

Greetings everyone.

I have 2 quick questions about ao/ao.m4, ogg/ogg.m4, and vorbis/vorbis.m4.

1. Is there any reason that the macros are named AM_PATH_AO, AM_PATH_OGG,
and AM_PATH_VORBIS?  Can we change them to something else?

I ran into a problem when trying to add support for ogg/vorbis into a
package today:

Automake assumes that anything beginning with AM_ belongs to automake --
these two macros are actually infringing on the automake namespace.  This
can cause problems if you don't include *.m4 by value in acinclude.m4 --
if you sinclude(ogg.m4) for example, aclocal won't be able to find
AM_PATH_OGG because it doesn't understand sinclude, and it will generate
an error because it thinks that some internal automake macro was not
found.

The solution is to change the DEFUN name for these two m4 macros.
Perhaps CHECK_PATH_AO, CHECK_PATH_OGG, and CHECK_PATH_VORBIS.  Anything,
as long as it doesn't start with "AM_",

Sidenote: So the various vorbis-tools are currently ok because they copied
the entirety of ao.m4, ogg.m4, and vorbis.m4 into acinclude.m4, but
packages outside of the ogg/vorbis CVS tree may want to keep the .m4 files
as separate files so it's easier to plug in new versions.

2. The test in ogg.m4:

        if test "x$ogg_prefix" != "xNONE"

is not sufficient.  If you do not specify --with-ogg-prefix, $ogg_prefix
will be "", not "NONE".  I don't know where "NONE" came from, although
$ogg_prefix will be "no" if you specify --without-ogg-prefix (autoconf
2.13 and 2.52).

Is there some version of autoconf that will set $ogg_prefix to "NONE" in
some cases?  We could hedge our bets and make the test be:

        if test "x$ogg_prefix" != "xNONE" -a "$ogg_prefix" != "no" \
                -a "$ogg_prefix" != ""

The same problem exists in vorbis.m4 as well.


----

I can certainly make all the appropriate fixes in CVS myself, but I've
been MIA for so long that I didn't it would be kosher for me to just start
commiting to CVS.  :-)

{+} Jeff Squyres
{+} squyres at cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.