[vorbis-dev] oggenc and UTF-8 support on windows

[Peter Harris]

> >Maintainers: Feel free to look at the patch, but don't apply this to CVS.
In
> >addition to breaking building on *ix, it also breaks Win9x at runtime.
With
> >one exception: The patch to utf8.c is valid, and should be applied.
>
> utf8.c patch committed - but is this correct? The MultiByteToWideChar()
call
> is done twice (from looking at the code, the first seems to be to figure
> out how much space is needed, or something like that)

Yup. Exactly like that.

> - but now the codepage
> for the two is different (CP_ACP in one, GetConsoleCP() in the other).

Aaargh. My mistake. They both need to be CP_ACP.

> Of course, this IS windows, so maybe that makes perfect sense, and is
> correct.

I've seen windows do some pretty silly things before, but this silliness
belongs to me. :-)

Peter Harris

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.