[vorbis-dev] More information on exception

[Michael Smith]

At 06:09 PM 9/5/00 -0230, you wrote:
>
>
>On Wed, 6 Sep 2000, Michael Smith wrote:
>
>> I finally found time to try and investigate this one - but didn't get
>> anywhere. I couldn't reproduce this. Could you send me (offlist) a file
>> that is triggering this problem?
>
>Here is a link to a test file:
>    http://www.cs.mun.ca/~chris3/sine.wav.gz
>
>The domain error occurs twice at about half way through the encoding,
>using mode E.
>

I couldn't get this problem to trigger using mainline, but on the post-b2 branch, it did occur (not halfway through the file, though). When doing this, the previous problems I noted (unrelated FPEs) went away, so maybe that was just something weird happening.

Anyway, the problem was related to precision (hence the problems on the post-b2 branch, which uses floats instead of doubles). If you were using mainline, I guess your compiler was just doing things marginally differently. On the final iteration of a smoothing loop, a check wasn't being made for negatives (which DO happen because of precision problems) - so it should be fixed now. 
I haven't committed it to mainline yet, but I'll do so in a few minutes. 

Also, I guess this (and any other fixes) need adding to the branch Jack is working on (reorganisation of everything). 

Chris - could you confirm that this fix stops the problems you were having, and that there aren't any others? 

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.