[vorbis-dev] vorbis module: Makefile cleaning

[Jack Moffitt]

> psytune_LDADD = .libs/libvorbis.a

this was added (i modified it though) but just wanted to let you know that
this is not the correct thing to do :)

it should be:

psytune_LDFLAGS = -static
psytune_LDADD = libvorbis.la

> oh yah.  psytune.c should now include "backends.h" at the beginning, and
> there are two lines where the frameno --> granulepos name change was missed.

done.

> Similarly, it might be an idea to reinstate the 'selftest' target, even though
> you normally wouldn't make it.
> 
> I also have rules to make the special library versions
> e.g. --- vorbis/Makefile.am with
> train_lsp:
>         $(MAKE) all CFLAGS="@CFLAGS@ -DTRAIN_LSP"
> analysis:
>         $(MAKE) all CFLAGS="@CFLAGS@ -DANALYSIS"
> both:
>         $(MAKE) all CFLAGS="@CFLAGS@ -DTRAIN_LSP -DANALYSIS"

I'll wait for monty's thoughts on this one.  I suggested this before and
he told me not to do it :)

> Heh and wouldn't it be nice to support --program-prefix and friends so that one
> could switch easily between 'stable' and 'development' binaries?

That's already supported silly.  --with-ogg-prefix --with-vorbis-prefix
--with-ao-prefix is all supported.

> Just some ideas for beta3 niceties (as if you didn't have enough),

thanks :)

jack.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.