[vorbis-dev] Makefile.in for installing headers

[Tomasz Wegrzanowski]

On Wed, Jun 21, 2000 at 09:18:18AM +0200, wrobell wrote:
> On Tue, Jun 20, 2000 at 07:14:29PM +0200, Tomasz Wegrzanowski wrote:
> > On Tue, Jun 20, 2000 at 01:35:44PM +0200, wrobell wrote:
> > > On Tue, Jun 20, 2000 at 12:31:47PM +0200, Tomasz Wegrzanowski wrote:
> > > [...]
> > > > install: all
> > > > 	mkdir -p @prefix@/include/vorbis
> > > > 	mkdir -p @prefix@/include/vorbis/book
> > > > 	cp -a vorbis/*.h @prefix@/include/vorbis/
> > > > 	cp -a vorbis/book/*.vqh @prefix@/include/vorbis/book/
> > > > 
> > > > uninstall:
> > > > 	rm -R @prefix@/include/vorbis
> > > 
> > > What about using "install" instead of mkdir and cp?
> > 
> > <I'm asking, not claiming you're wrong.>
> i know :)

Did you know how many people starts flamewar
seeing `Is there any benefit' question ? :-)

> > Is there any benefit of doing so ?
> minimal set of tools... and it is nice i think

So this is 100% stylistic issue ?

> > > And maybe all install lines i.e.
> > > 
> > > 	install -d @prefix@/include/vorbis
> > > 
> > > change to
> > > 
> > > 	install -d $DESTDIR at prefix@/include/vorbis
> > >                     ^^^
> > > 
> > > so one can install with
> > > 
> > >   make DESTDIR=$RPM_BUILD_ROOT install
> > > 
> > > It is very useful when creating rpm packages (.deb too?).
> > 
> > <I'm asking, not claiming you're wrong.>
> i know :)
> > Any reason not to add parameter --prefix to ./configure ?
> > @prefix@ isn't used by sources, only by Makefile's.
> with prefix you specify where binaries are installed in
> system, but DESTDIR is useful when creating distro packages,
> only then, i am sure that one or two in near future will make
> such patch, so you see my proposal

Oh, now see.
Of course:
$(DESTDIR)@prefix@/include/vorbis
 ^       ^
And vorbis-tools/Makefile.in need to be fixed too.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/