[vorbis-dev] Some new code for Ogg Drop

[Lars Brubaker]

> +//***************************************************************
> **********
> > ********************************************
>
> Don't change cosmetics; it's unnecessary, and not everybody
> shares your idea of good-looking code.
>
> > +       if(file == NULL)
> > +       {
> > +               return;
> > +       }
> >
> > -       if (file == NULL) return;
>
> Same.
>
> > +       if(pCurrentDecopressingFileName &&
> strcmp(pCurrentDecopressingFileName,
> > file) == 0)
>
> Is this a typo? (decompressing)
>
> Lots of other cosmetics (like braces on one-statement if's), you renamed a
> variable to something very long; please take this out, and resubmit. The
> actual changes you made look good, I think, only your patch doesn't.

I think you are absolutely correct.  However, I have a tremendous amount of
other code to write and I can't possibly spend more time re-submitting this.

If there is anything that you find useful please incorporate it into the
code.

Lars.

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.