[vorbis-dev] Modification requests / question

Monty xiphmont at xiph.org
Mon Dec 25 18:34:29 PST 2000



On Mon, Dec 25, 2000 at 09:43:34PM +0100, Attila Padar wrote:
> Hello!
> 1.
> You should modify the 'vorbis_ftoi(f)' for the undefinied OS/compiler
> in the 'os.h' on this way:
> old:
> static int vorbis_ftoi(double f){
>    return (int)(f+.5);
>   }
> new:
> #define vorbis_ftoi(f) ((int)(f+.5f))

It can't be profiled/traced in this case, although the suggestion may
still be sensible.

> Because in some cases we don't use this function, and the compiler writes
> many error messages.

MSVC?

> 2. Could you write a frequency and bitrate independent 'mode' and 'vqh'
>     tables for the Vorbis encoder?
>     Could you implement the table generation into the program (removing the
> fixed
>     and large mode & vqh tables)?
>     (So, you should write a table generation routine with 2 input values:
> freq and bitrate)

It's been this way for a while now.  See libvorbisenc.

Monty

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the Vorbis-dev mailing list