[vorbis-dev] CFLAGS / LDFLAGS

[Jeff Squyres]

On Sun, 24 Dec 2000, Michael Smith wrote:

> >- problems with static linking
> >- allowing compiles without gcc
> >- using the --prefix to find the ao, ogg, and vorbis libraries instead of
> >  having to use --with-ogg-prefix and friends
> >- fixes for compiling under Solaris with the native compilers (not gcc)
>
> I haven't touched all the build stuff, but the code fixes should be
> there. Could you test? I don't have access currently to the solaris
> machine I usually use.

A quick "cvs diff" on my tree still shows that many of the fixes aren't
there.  Most of the build stuff still isn't there (there are several
changes that need to be made for both static linking and non-gcc builds in
various Makefile.am's), and a few code things aren't there.

Here's a "cvs diff -c" on the code changes (leaving out the Makefile.am
changes for the moment):

Index: vorbis-tools/oggenc/audio.c
===================================================================
RCS file: /usr/local/cvsroot/vorbis-tools/oggenc/audio.c,v
retrieving revision 1.6
diff -c -r1.6 audio.c
*** vorbis-tools/oggenc/audio.c	2000/12/24 06:17:40	1.6
--- vorbis-tools/oggenc/audio.c	2000/12/30 01:39:12
***************
*** 14,19 ****
--- 14,21 ----
  #include <stdio.h>
  #include <string.h>
  #include <sys/types.h>
+ #include <malloc.h>
+ #include <alloca.h>
  #include "audio.h"
  #include "platform.h"

Index: vorbis-tools/vorbiscomment/vorbiscomment.c
===================================================================
RCS file: /usr/local/cvsroot/vorbis-tools/vorbiscomment/vorbiscomment.c,v
retrieving revision 1.3
diff -c -r1.3 vorbiscomment.c
*** vorbis-tools/vorbiscomment/vorbiscomment.c	2000/10/03 02:21:23	1.3
--- vorbis-tools/vorbiscomment/vorbiscomment.c	2000/12/30 01:39:12
***************
*** 205,211 ****
               * header packets.
               */

! 	    //vorbis_analysis_init(&vd,&vi);
              memset(&vd,0,sizeof(vd));
              vd.vi = &vi; /* Ugly hack? Hell yeah! */

--- 205,211 ----
               * header packets.
               */

! 	    /*vorbis_analysis_init(&vd,&vi);*/
              memset(&vd,0,sizeof(vd));
              vd.vi = &vi; /* Ugly hack? Hell yeah! */

> Oh, and I haven't changed vorbiscomment, because it doesn't work
> properly anymore anyway, I think. Don't use it.

Ok.  I included the vorbiscomment.c patch just for the heck of it, anyway.
:-)

{+} Jeff Squyres
{+} squyres at cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'vorbis-dev-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.