[tremor] PATCH: Corrected return value for ov_time_tell()

Owen G. Emry oemry at patriot.net
Mon Oct 7 22:37:38 PDT 2002



Unless I've misunderstood the intended behavior, I believe I've found a bug 
in vorbisfile.

This is the last line of ov_time_tell() in Tremor CVS from 2002-09-30:

return(time_total + (vf->pcm_offset-pcm_total) / vf->vi[link].rate * 1000);

(I added the whitespace for my own sanity.)  As is, it always returns a 
multiple of 1000, since it obviously devides before it multiples.  Changing 
it as follows fixes the problem:

return(time_total + (1000 * vf->pcm_offset-pcm_total) / vf->vi[link].rate);

Regards,
Owen

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to 'tremor-request at xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is needed.
Unsubscribe messages sent to the list will be ignored/filtered.



More information about the Tremor mailing list