[theora] Indexing Ogg files for faster seeking

[Jason Self]

On Nov 8, 2009, at 1:29 PM, Chris Pearce wrote:

> A testcase would very helpful. :) I'm actually kinda worried about
> hitting this error,  it could be caused by us getting an incorrect
> duration, and that sounds like fun to fix.

On 11/12/2009 2:48 PM,  Jason Self wrote:

>> Okay: I managed to find a file that results in:
>>
>> WARNING: Recorded more keyframes than there's room for in the  
>> index. We must have miscalculated index size. Not writing index.
>>
>> ...but the input file is almost 3.4GB. I'm sure you don't want a  
>> file that large, so I'm using dd to create a smaller version. A  
>> small 10MB version didn't report this problem so it looks like I  
>> need to experiment to find a size that reports this problem, while  
>> also not being the entire file. More soon (hopefully, depending on  
>> how long this process takes.)

On Nov 11, 2009, at 7:26 PM, Chris Pearce wrote:

> Hi Jason,
>
> Thanks for trying to reproduce this. I have spotted a potential  
> cause for this problem, and I've attached a patch... Would you be  
> able to apply the patch to your local tree and see if the error  
> still happens? I'm not sure that it will fix it, but it's worthwhile  
> ruling it out at least.
>
> A smaller testcase would be nice, but I can handle a 3.4GB download,  
> if it's not too much of a hassle for you to upload it somewhere that  
> I can get to it.
>
> Cheers,
> Chris P.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: index-record-sample.patch
Url: http://lists.xiph.org/pipermail/theora/attachments/20091114/10e9f2d9/attachment.txt 
-------------- next part --------------



Sorry for the delay; work has kept me very busy. I've applied your  
patch and it does seem to have solved it. I'll continue testing with  
other files and let you know if anything else pops up.