[theora-dev] VC6 Patch

Timothy B. Terriberry tterribe at email.unc.edu
Tue Oct 9 17:47:23 PDT 2007

Ralph Giles wrote:
> Anybody know if it's safe to remove the LL at the end of the constants 
> as the second half of the patch does?

Yes, integer constants are promoted to the type required to represent
them. There's some subtleties with signedness (-32768 gets promoted to a
long on machines with a 16-bit int), but unless you're doing things like
~0ULL instead of 0xFFFFFFFFFFFFFFFF, you shouldn't have problems.

I applied the patch, sans the /D "TH_REALLY_NO_ASSEMBLY". The #error
that results is intentional, and users should be forced to manually
disable it if they still want to compile with MSVC. If they don't like
it, they should complain to their compiler for not supporting #warning.

More information about the theora-dev mailing list