<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=iso-8859-1">
<META content="MSHTML 6.00.6000.16587" name=GENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY style="MARGIN: 4px 4px 1px; FONT: 10pt Tahoma" bgColor=#ffffff>
<DIV><FONT face=Arial>Mike,</FONT></DIV>
<DIV><FONT face=Arial></FONT> </DIV>
<DIV><FONT face=Arial>I played briefly with the echo canceller on the C5509A
back in May 2006. I got the same compiler warnings, and sent a message to
the list which included this:</FONT></DIV>
<DIV><FONT face=Arial></FONT> </DIV>
<DIV><FONT face=Arial>"I got several compiler warnings for "shift out of range"
in mdf.c, which I <BR>fixed by adding EXTEND32 to all of the SHL32s with 16 bit
operands <BR>(st->frame_size in 6 places, st->wtmp2 in 1
place)."</FONT></DIV>
<DIV><FONT face=Arial></FONT> </DIV>
<DIV><FONT face=Arial>I sent a patch with some fixes later that month, but I
have not built the echo canceller since then (no room for it). It is very
likely that you are seeing the same issue, and the fix should be the same
also. </FONT><FONT face=Arial>The trickier problems are the ones that the
compiler does not find. EXTEND32 is usually the cure there
also.</FONT></DIV>
<DIV><FONT face=Arial></FONT> </DIV>
<DIV><FONT face=Arial>Now that I look at mdf.c, though, W is declares as
spx_word32_t, so there should not be a problem, unless spx_word32_t is being
mapped to 16-bits. That should not happen if you compile with
CONFIG_TI_C54X defined. This is odd.</FONT></DIV>
<DIV><FONT face=Arial></FONT> </DIV>
<DIV><FONT face=Arial>- Jim</FONT></DIV>
<DIV><FONT face=Arial></FONT> </DIV>
<DIV><FONT face=Arial></FONT> </DIV>
<BLOCKQUOTE
style="PADDING-RIGHT: 0px; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #000000 2px solid; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="BACKGROUND: #e4e4e4; FONT: 10pt arial; font-color: black"><B>From:</B>
<A title=Michael.Jacobson@ultratec.com
href="mailto:Michael.Jacobson@ultratec.com">Michael Jacobson</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A
title=jean-marc.valin@usherbrooke.ca
href="mailto:jean-marc.valin@usherbrooke.ca">Jean-Marc Valin</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A title=speex-dev@xiph.org
href="mailto:speex-dev@xiph.org">speex-dev@xiph.org</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Tuesday, January 22, 2008 9:54
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [Speex-dev] Shift count
warning messages</DIV>
<DIV><BR></DIV>
<DIV>yes, our DSP is 16 bit based, and if those bits of code aren't using 32
bit variables then yes that is what the warnings would be. Does this
mean that the preprocessor and echo canceller won't work as well because of
this?</DIV>
<DIV> </DIV>
<DIV>-Mike<BR><BR>>>> Jean-Marc Valin <<A
href="mailto:jean-marc.valin@usherbrooke.ca">jean-marc.valin@usherbrooke.ca</A>>
01/18/08 8:42 PM >>><BR></DIV>
<DIV style="COLOR: #000000">I think these warnings are due to your DSP being
16-bit and that bit of<BR>code not being 16-bit safe (unlike the encoder and
decoder). Can you<BR>confirm?<BR><BR>
Jean-Marc<BR><BR>Michael Jacobson a écrit :<BR>> Hi, I'm using 1.2beta3 on
a 5416 DSP<BR>> <BR>> I have been getting warning messages that
say:<BR>> "kiss_fft.c", line 142: warning: shift count is too
large<BR>> <BR>> <BR>> I've noticed this on the echo
canceller and the preprocessor. all<BR>> pretty much related to these
two lines of code:<BR>> <BR>> kiss_fft<BR>>
C_MUL4(scratch[0],Fout[m] , *tw1 );<BR>> <BR>> mdf.c<BR>>
st->wtmp2[i] =
EXTRACT16(PSHR32(st->W[j*N+i],NORMALIZE_SCALEDOWN+16));<BR>>
<BR>> Is there some kind of switch I was supposed to throw to not get
these<BR>> messages? if not-are they hurting anything?<BR>>
<BR>> -Mike<BR>> <BR>> <BR>> <BR>>
------------------------------------------------------------------------<BR>>
<BR>> _______________________________________________<BR>> Speex-dev
mailing list<BR>> Speex-dev@xiph.org<BR>> <A
href="http://lists.xiph.org/mailman/listinfo/speex-dev">http://lists.xiph.org/mailman/listinfo/speex-dev</A><BR></DIV><BR><BR>__________
Information from ESET NOD32 Antivirus, version of virus signature database
2815 (20080122) __________<BR><BR>The message was checked by ESET NOD32
Antivirus.<BR><BR><A href="http://www.eset.com">http://www.eset.com</A><BR>
<P>
<HR>
<P></P>_______________________________________________<BR>Speex-dev mailing
list<BR>Speex-dev@xiph.org<BR>http://lists.xiph.org/mailman/listinfo/speex-dev<BR><BR><BR><BR>__________
Information from ESET NOD32 Antivirus, version of virus signature database
2815 (20080122) __________<BR><BR>The message was checked by ESET NOD32
Antivirus.<BR><BR>http://www.eset.com<BR></BLOCKQUOTE></BODY></HTML>