[Speex-dev] GCC/ELF Visibility patch (fwd)

Thorvald Natvig thorvald at natvig.com
Sat Mar 29 07:09:17 PDT 2008


I just tried, and Win32 support will require adding __declspec to all 
the header files as well, or you will get redifinition errors. 
Alternately you can just add
#define EXPORT
to win32/config.h; this will give the same exact result you had before 
the patch.

Jean-Marc Valin wrote:
> Alexander, what do you think about that when it comes to Win32 support?
>
> 	Jean-Marc
>
> Thorvald Natvig a écrit :
>   
>> Hi,
>>
>> I've attached a patch against SVN r14645 which adds GCC visibility
>> information to all symbols exported from libspeex.so and libspeexdsp.so.
>> It includes a configure.ac change to test that both the compiler flags
>> and __attribute__((visibility)) works, and if so will
>> #define EXPORT __attribute__((visibility("default")))
>> and if not
>> #define EXPORT
>>
>> I've attached a diff output of "nm -C -D" for both libraries (compiled
>> on x86_64 Linux), and verified that none of the symbols removed are
>> mentioned in any header file under include/
>>
>> If this gets accepted, I'll make a similar effort for Win32 (where it
>> hopefully should suffice to #define EXPORT in the config.h)
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Speex-dev mailing list
>> Speex-dev at xiph.org
>> http://lists.xiph.org/mailman/listinfo/speex-dev
>>     



More information about the Speex-dev mailing list