[Speex-dev] [PATCH] fix gcc 3.4 warnings

Jean-Marc Valin Jean-Marc.Valin at USherbrooke.ca
Mon Sep 5 15:54:18 PDT 2005

> there is nothing wrong with "start" and "end", but in the Ubicom OS
> there is a global function called "start()" which gives the warning:
>   libspeex/ltp.c:573: warning: declaration of "start" shadows a global declaration
>   build/include/UbicomSDK.h:5651: warning: shadowed declaration is here

Since it's just a warning and just on one OS, I'll leave it that way.

> also this line gives a warning:
>             v1=(int)floor(st->vbr_quality);
> libSpeex/libspeex/nb_celp.c: In function `nb_encode':
> libSpeex/libspeex/nb_celp.c:465: warning: cast does not match function type

No clue what this warning is, I'll have to dig a bit.

> my CFLAGS include this:
> perhaps we should add a few of these to libspeex ?

I usually compile with several warning flags, but I prefer not to impose
any (especially since not everyone uses gcc!).

> attached is a new and less intrusive patch, please review.. ;)

Much less intrusive indeed. Applied to SVN.


Jean-Marc Valin <Jean-Marc.Valin at USherbrooke.ca>
Université de Sherbrooke
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.xiph.org/pipermail/speex-dev/attachments/20050906/945bc983/attachment.pgp

More information about the Speex-dev mailing list