From fuhsaz+cdparanoia at cryptic.li Mon Dec 12 23:21:35 2016 From: fuhsaz+cdparanoia at cryptic.li (fuhsaz+cdparanoia at cryptic.li) Date: Mon, 12 Dec 2016 18:21:35 -0500 Subject: [Paranoia-dev] Bug report: paranoia mode reads incorrect track, -Z reads correct track In-Reply-To: <20160810224344.GA29723@hithlum.hss> References: <20160810224344.GA29723@hithlum.hss> Message-ID: <20161212232135.GA1738@hithlum.lan> On Wed, Aug 10, 2016 at 06:43:44PM -0400, fuhsaz+cdparanoia at cryptic.li wrote: > While working on some software based on cdparanoia-III-10.2[0], I have > discovered what I think is a bug in cdparanoia: > > Writing a wav[1] with md5sum 3b265ba06de8cd27f200e79447c58035 to a disc > and then ripping in default full-paranoia mode will result in a track > with incorrect md5sum 063fa2d2df295f7dbfad8d75ce0aeafa -- however, > ripping with paranoia disabled (-Z) will yield the correct track rip.[2] A developer who wishes to remain anonymous has contributed a bugfix, with two alternative implementations: > Pretty sure I fixed the cdparanoia bug. It actually wasn't in a silence > block. There were 2 identical 109 samples of data in the track right > near each other. cdparanoia was matching the second one with the first > one and saying it was jitter. > This fix doesn't lose out on any error correcting capablities. In the > case of multiple matching runs it picks the one with the smallest > (absolute value) offset (diff 1) or the one with the longest match (diff > 2). Since multiple matching runs should be extremely rare, the impact of > this change on other rips should be almost nonexistent. Both diffs fix > the Julie Roberts track 5 bug. I have attached the two diffs. -- Samantha Baldwin - logik.li -------------- next part -------------- A non-text attachment was scrubbed... Name: cdparanoia-longest-match.patch Type: text/x-diff Size: 2553 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: cdparanoia-smallest-offset.patch Type: text/x-diff Size: 2668 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: